From: Wenjie <qwjhust@gmail.com>
To: jaegeuk@kernel.org, chao@kernel.org, guoweichao@oppo.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Cc: hustqwj@hust.edu.cn, Wenjie Qi <qwjhust@gmail.com>
Subject: [PATCH] f2fs: fix NULL pointer dereference in f2fs_submit_page_write()
Date: Sun, 7 Jan 2024 21:12:36 +0800 [thread overview]
Message-ID: <20240107131236.625-1-qwjhust@gmail.com> (raw)
From: Wenjie Qi <qwjhust@gmail.com>
BUG: kernel NULL pointer dereference, address: 0000000000000014
RIP: 0010:f2fs_submit_page_write+0x6cf/0x780 [f2fs]
Call Trace:
<TASK>
? show_regs+0x6e/0x80
? __die+0x29/0x70
? page_fault_oops+0x154/0x4a0
? prb_read_valid+0x20/0x30
? __irq_work_queue_local+0x39/0xd0
? irq_work_queue+0x36/0x70
? do_user_addr_fault+0x314/0x6c0
? exc_page_fault+0x7d/0x190
? asm_exc_page_fault+0x2b/0x30
? f2fs_submit_page_write+0x6cf/0x780 [f2fs]
? f2fs_submit_page_write+0x736/0x780 [f2fs]
do_write_page+0x50/0x170 [f2fs]
f2fs_outplace_write_data+0x61/0xb0 [f2fs]
f2fs_do_write_data_page+0x3f8/0x660 [f2fs]
f2fs_write_single_data_page+0x5bb/0x7a0 [f2fs]
f2fs_write_cache_pages+0x3da/0xbe0 [f2fs]
...
It is possible that other threads have added this fio to io->bio
and submitted the io->bio before entering f2fs_submit_page_write().
At this point io->bio = NULL.
If is_end_zone_blkaddr(sbi, fio->new_blkaddr) of this fio is true,
then an NULL pointer dereference error occurs at bio_get(io->bio).
In this case, the code to determine the zone end can simply be skipped.
Signed-off-by: Wenjie Qi <qwjhust@gmail.com>
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 1896928cae77..d08e92bb2621 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1100,7 +1100,7 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio)
goto next;
out:
#ifdef CONFIG_BLK_DEV_ZONED
- if (f2fs_sb_has_blkzoned(sbi) && btype < META &&
+ if (io->bio && f2fs_sb_has_blkzoned(sbi) && btype < META &&
is_end_zone_blkaddr(sbi, fio->new_blkaddr)) {
spin_lock_bh(&sbi->available_active_zones_lock);
if (sbi->available_active_zones > 0) {
--
2.34.1
next reply other threads:[~2024-01-07 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-07 13:12 Wenjie [this message]
2024-01-09 7:08 ` 亓文杰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240107131236.625-1-qwjhust@gmail.com \
--to=qwjhust@gmail.com \
--cc=chao@kernel.org \
--cc=guoweichao@oppo.com \
--cc=hustqwj@hust.edu.cn \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®