From: Andrew Morton <akpm@linux-foundation.org>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: irogers@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] lib min_heap: Min heap optimizations
Date: Tue, 9 Jan 2024 22:14:47 -0800 [thread overview]
Message-ID: <20240109221447.3d5e8878b0d6424d26666be5@linux-foundation.org> (raw)
In-Reply-To: <20240103205259.2108410-1-visitorckw@gmail.com>
On Thu, 4 Jan 2024 04:52:57 +0800 Kuan-Wei Chiu <visitorckw@gmail.com> wrote:
> Hello,
>
> The purpose of this patch series is to enhance the existing min heap
> implementation. The optimization focuses on both the heap construction
> process and the number of comparisons made during the heapify
> operation.
>
The patches look nice, but the only user of this code is
kernel/events/core.c and the developers of that code aren't cc'ed, so
please rectify that.
Has Ian commented on these changes?
The amount of inlining in min_heap.h is amazing. Was there some
special reason for this? It makes min_heap somewhat unsuitable for
more general use.
prev parent reply other threads:[~2024-01-10 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 20:52 Kuan-Wei Chiu
2024-01-03 20:52 ` [PATCH v2 1/2] lib min_heap: Optimize number of calls to min_heapify() Kuan-Wei Chiu
2024-01-03 20:52 ` [PATCH v2 2/2] lib min_heap: Optimize number of comparisons in min_heapify() Kuan-Wei Chiu
2024-01-10 6:14 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109221447.3d5e8878b0d6424d26666be5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®