From: Junwen Wu <wudaemon@163.com>
To: bristot@redhat.com
Cc: bsegall@google.com, dietmar.eggemann@arm.com,
juri.lelli@redhat.com, laoar.shao@gmail.com,
linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com,
peterz@infradead.org, rostedt@goodmis.org,
vincent.guittot@linaro.org, vschneid@redhat.com,
wudaemon@163.com
Subject: Re: [PATCH v3] sched/stats: Fix rt/dl task's sched latency statistics error in sched_stat_wait trace_point
Date: Wed, 10 Jan 2024 12:27:26 +0000 [thread overview]
Message-ID: <20240110122726.4309-1-wudaemon@163.com> (raw)
In-Reply-To: <87d33909-ef8c-43a6-a556-d01fe692d5cd@redhat.com>
>This error happens when the rt task balances off the source CPU because
>the dequeue operation is not updating the sched_statistics. So, follow
>update_stats_wait_end_fair() and update the stats. Do the same for
>SCHED_DEADLINE.
>[ feel free to change ]
ok
>> + /*
>> + * Mark the end of the wait period
>> + * if dequeueing a waiting task.
>> + */
>make this a single line comment.
ok
--
Best regards
prev parent reply other threads:[~2024-01-10 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 3:17 Junwen Wu
2024-01-04 11:02 ` Daniel Bristot de Oliveira
2024-01-10 12:27 ` Junwen Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110122726.4309-1-wudaemon@163.com \
--to=wudaemon@163.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®