From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Suman Ghosh <sumang@marvell.com>,
Jakub Kicinski <kuba@kernel.org>, Sasha Levin <sashal@kernel.org>,
sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 5.15 47/47] octeontx2-af: Fix max NPC MCAM entry check while validating ref_entry
Date: Tue, 16 Jan 2024 14:57:50 -0500 [thread overview]
Message-ID: <20240116195834.257313-47-sashal@kernel.org> (raw)
In-Reply-To: <20240116195834.257313-1-sashal@kernel.org>
From: Suman Ghosh <sumang@marvell.com>
[ Upstream commit 4ebb1f95e0c3c3e0eec5bb21aa43097580c4b6e4 ]
As of today, the last MCAM entry was not getting allocated because of
a <= check with the max_bmap count. This patch modifies that and if the
requested entry is greater than the available entries then set it to the
max value.
Signed-off-by: Suman Ghosh <sumang@marvell.com>
Link: https://lore.kernel.org/r/20240101145042.419697-1-sumang@marvell.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
index 8b16738e249f..70b4f2a3b02f 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
@@ -2625,18 +2625,17 @@ int rvu_mbox_handler_npc_mcam_alloc_entry(struct rvu *rvu,
rsp->entry = NPC_MCAM_ENTRY_INVALID;
rsp->free_count = 0;
- /* Check if ref_entry is within range */
- if (req->priority && req->ref_entry >= mcam->bmap_entries) {
- dev_err(rvu->dev, "%s: reference entry %d is out of range\n",
- __func__, req->ref_entry);
- return NPC_MCAM_INVALID_REQ;
- }
+ /* Check if ref_entry is greater that the range
+ * then set it to max value.
+ */
+ if (req->ref_entry > mcam->bmap_entries)
+ req->ref_entry = mcam->bmap_entries;
/* ref_entry can't be '0' if requested priority is high.
* Can't be last entry if requested priority is low.
*/
if ((!req->ref_entry && req->priority == NPC_MCAM_HIGHER_PRIO) ||
- ((req->ref_entry == (mcam->bmap_entries - 1)) &&
+ ((req->ref_entry == mcam->bmap_entries) &&
req->priority == NPC_MCAM_LOWER_PRIO))
return NPC_MCAM_INVALID_REQ;
--
2.43.0
prev parent reply other threads:[~2024-01-16 20:00 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 19:57 [PATCH AUTOSEL 5.15 01/47] wifi: rt2x00: restart beacon queue when hardware reset Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 02/47] selftests/bpf: satisfy compiler by having explicit return in btf test Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 03/47] selftests/bpf: Fix pyperf180 compilation failure with clang18 Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 04/47] selftests/bpf: Fix issues in setup_classid_environment() Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 05/47] scsi: lpfc: Fix possible file string name overflow when updating firmware Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 06/47] PCI: Add no PM reset quirk for NVIDIA Spectrum devices Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 07/47] bonding: return -ENOMEM instead of BUG in alb_upper_dev_walk Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 08/47] wifi: ieee80211: fix PV1 frame control field name Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 09/47] scsi: arcmsr: Support new PCI device IDs 1883 and 1886 Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 10/47] ARM: dts: imx7d: Fix coresight funnel ports Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 11/47] ARM: dts: imx7s: Fix lcdif compatible Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 12/47] ARM: dts: imx7s: Fix nand-controller #size-cells Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 13/47] wifi: ath9k: Fix potential array-index-out-of-bounds read in ath9k_htc_txstatus() Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 14/47] bpf: Add map and need_defer parameters to .map_fd_put_ptr() Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 15/47] bpf: Set need_defer as false when clearing fd array during map free Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 16/47] scsi: libfc: Don't schedule abort twice Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 17/47] scsi: libfc: Fix up timeout error in fc_fcp_rec_error() Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 18/47] net: mvmdio: Avoid excessive sleeps in polled mode Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 19/47] bpf: Guard stack limits against 32bit overflow Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 20/47] bpf: Set uattr->batch.count as zero before batched update or deletion Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 21/47] ARM: dts: rockchip: fix rk3036 hdmi ports node Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 22/47] ARM: dts: imx25/27-eukrea: Fix RTC node name Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 23/47] ARM: dts: imx: Use flash@0,0 pattern Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 24/47] ARM: dts: imx27: Fix sram node Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 25/47] ARM: dts: imx1: " Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 26/47] ionic: pass opcode to devcmd_wait Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 27/47] block/rnbd-srv: Check for unlikely string overflow Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 28/47] ARM: dts: imx25: Fix the iim compatible string Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 29/47] ARM: dts: imx25/27: Pass timing0 Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 30/47] ARM: dts: imx27-apf27dev: Fix LED name Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 31/47] ARM: dts: imx23-sansa: Use preferred i2c-gpios properties Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 32/47] ARM: dts: imx23/28: Fix the DMA controller node name Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 33/47] net: dsa: mv88e6xxx: Fix mv88e6352_serdes_get_stats error path Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 34/47] block: prevent an integer overflow in bvec_try_merge_hw_page Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 35/47] md: Whenassemble the array, consult the superblock of the freshest device Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 36/47] arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 37/47] arm64: dts: qcom: msm8998: Fix 'out-ports' " Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 38/47] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU devices Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 39/47] libbpf: Fix NULL pointer dereference in bpf_object__collect_prog_relos Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 40/47] wifi: rtlwifi: add calculate_bit_shift() Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 41/47] wifi: rtlwifi: rtl8723{be,ae}: using calculate_bit_shift() Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 42/47] wifi: cfg80211: free beacon_ies when overridden from hidden BSS Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 43/47] Bluetooth: qca: Set both WIDEBAND_SPEECH and LE_STATES quirks for QCA2066 Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 44/47] Bluetooth: L2CAP: Fix possible multiple reject send Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 45/47] bridge: cfm: fix enum typo in br_cc_ccm_tx_parse Sasha Levin
2024-01-16 19:57 ` [PATCH AUTOSEL 5.15 46/47] i40e: Fix VF disable behavior to block all traffic Sasha Levin
2024-01-16 19:57 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116195834.257313-47-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=stable@vger.kernel.org \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®