From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4738841C8D; Tue, 16 Jan 2024 20:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705435413; cv=none; b=R0AF2Wh48RLkgAFOHVvP5/qpFmmcUNUD6saTfiKbu7rhOFY/AGkXPSK/s9N1P/mimgq1+clCL1ggeAeakbmVaS0L19kgFK3J6JjOtD/cyNLnrAqgi9lweeCAH+Nxa7HIvE+/Y5aGIn1umH+kOw7wJS2ed3LQMecthwksBWXSrUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705435413; c=relaxed/simple; bh=kB8naHT2NG4P0oWELwQgQg5BKDHjBl2vgpSgreY5yRQ=; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version:Content-Type:X-stable: X-Patchwork-Hint:X-stable-base:Content-Transfer-Encoding; b=MC45PRpncMxT1GpmnEKh1hmA719KoAb+/4cJHJ3lnfHavgHA6Bn/l/6J01+JncAUIjDMO8BJ9rhzqtyfUoz3Z1noqaCNb9YsT1miTVNItctfp9t6q0YOnpt63HMnXOKYZ8V38POYrZEbubGjn6L+Q+lRvUANZn6mhxWBi6NieuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aPmurw89; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aPmurw89" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1426C433C7; Tue, 16 Jan 2024 20:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705435412; bh=kB8naHT2NG4P0oWELwQgQg5BKDHjBl2vgpSgreY5yRQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aPmurw891cOHjVJTOpWpexn15i+dr1jMUNwm0cQYBdEP9idvhl5k6yKgx03BFsgnm P0SCQZM4UuccXBuu4El/eWfqucGCe9qUIkRIh20KCFT93b79hRNL9BV7aBGdw7YVzy +bTNALD8oU/+CtZJW+ttlNpL/eyWKgdyABSf0zzvCCLIIfSVkqEBYwezD9EmXyehXi ax/dKi/s8gb5czgNQGFiKBi5YfYJ5hm93wHhG+rY2bs/nvZJLaU6n35pOdG3WYUWYQ NbbMJEjDtnoXTtdJF7xwlcO/rJnqbnVg1WJSUZ4UrWKS7/02LurukvSrWWAU0/WMlg bBGBElO0ofypA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Minsuk Kang , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Kalle Valo , Sasha Levin , kvalo@kernel.org, linux-wireless@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 10/31] wifi: ath9k: Fix potential array-index-out-of-bounds read in ath9k_htc_txstatus() Date: Tue, 16 Jan 2024 15:02:19 -0500 Message-ID: <20240116200310.259340-10-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116200310.259340-1-sashal@kernel.org> References: <20240116200310.259340-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.267 Content-Transfer-Encoding: 8bit From: Minsuk Kang [ Upstream commit 2adc886244dff60f948497b59affb6c6ebb3c348 ] Fix an array-index-out-of-bounds read in ath9k_htc_txstatus(). The bug occurs when txs->cnt, data from a URB provided by a USB device, is bigger than the size of the array txs->txstatus, which is HTC_MAX_TX_STATUS. WARN_ON() already checks it, but there is no bug handling code after the check. Make the function return if that is the case. Found by a modified version of syzkaller. UBSAN: array-index-out-of-bounds in htc_drv_txrx.c index 13 is out of range for type '__wmi_event_txstatus [12]' Call Trace: ath9k_htc_txstatus ath9k_wmi_event_tasklet tasklet_action_common __do_softirq irq_exit_rxu sysvec_apic_timer_interrupt Signed-off-by: Minsuk Kang Acked-by: Toke Høiland-Jørgensen Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20231113065756.1491991-1-linuxlovemin@yonsei.ac.kr Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c index ee021738bef0..be4fa41bdb12 100644 --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c @@ -647,9 +647,10 @@ void ath9k_htc_txstatus(struct ath9k_htc_priv *priv, void *wmi_event) struct ath9k_htc_tx_event *tx_pend; int i; - for (i = 0; i < txs->cnt; i++) { - WARN_ON(txs->cnt > HTC_MAX_TX_STATUS); + if (WARN_ON_ONCE(txs->cnt > HTC_MAX_TX_STATUS)) + return; + for (i = 0; i < txs->cnt; i++) { __txs = &txs->txstatus[i]; skb = ath9k_htc_tx_get_packet(priv, __txs); -- 2.43.0