From: Conor Dooley <conor@kernel.org>
To: Primoz Fiser <primoz.fiser@norik.com>
Cc: Mathieu Othacehe <othacehe@gnu.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>, Li Yang <leoyang.li@nxp.com>,
Stefan Wahren <wahrenst@gmx.net>,
Christoph Stoidner <c.stoidner@phytec.de>,
Wadim Egorov <w.egorov@phytec.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, upstream@lists.phytec.de
Subject: Re: [PATCH v2 2/2] arm64: dts: imx93-phycore-segin: Add Phytec i.MX93 Segin
Date: Thu, 18 Jan 2024 10:19:23 +0000 [thread overview]
Message-ID: <20240118-regretful-viewer-8d7dfc7a0802@spud> (raw)
In-Reply-To: <c1ef5c08-1ae9-4a22-8ca9-47673c023e1e@norik.com>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On Thu, Jan 18, 2024 at 10:58:36AM +0100, Primoz Fiser wrote:
> > + reg_usdhc2_vmmc: regulator-usdhc2 {
> > + compatible = "regulator-fixed";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
> > + regulator-name = "VSD_3V3";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
>
> Order properties here alphabetically like in the downstream kernel.
>
> Comment applies for the entire patch.
Please do not order properties alphabetically. Instead, please read the
new documentation on property ordering that makes explicit what has just
been convention until now:
https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=for-next&id=83a368a3fc8ae8538bccb713dc0cae9eacc04790#n112
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-01-18 10:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 7:49 [PATCH v2 0/2] Add Phytec i.MX93 Segin support Mathieu Othacehe
2024-01-17 7:49 ` [PATCH v2 1/2] dt-bindings: arm: fsl: Add i.MX93 PHYTEC with Segin Mathieu Othacehe
2024-01-17 8:15 ` Krzysztof Kozlowski
2024-01-18 9:10 ` Primoz Fiser
2024-01-17 7:49 ` [PATCH v2 2/2] arm64: dts: imx93-phycore-segin: Add Phytec i.MX93 Segin Mathieu Othacehe
2024-01-18 9:58 ` Primoz Fiser
2024-01-18 10:19 ` Conor Dooley [this message]
2024-01-18 13:43 ` Mathieu Othacehe
2024-01-18 15:56 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118-regretful-viewer-8d7dfc7a0802@spud \
--to=conor@kernel.org \
--cc=c.stoidner@phytec.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=othacehe@gnu.org \
--cc=primoz.fiser@norik.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=upstream@lists.phytec.de \
--cc=w.egorov@phytec.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®