mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: hverkuil@xs4all.nl, mchehab@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	kernel@collabora.com,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>
Subject: [PATCH v17 8/8] media: verisilicon: Support deleting buffers on capture queue
Date: Fri, 19 Jan 2024 10:49:44 +0100	[thread overview]
Message-ID: <20240119094944.26763-9-benjamin.gaignard@collabora.com> (raw)
In-Reply-To: <20240119094944.26763-1-benjamin.gaignard@collabora.com>

Allow to delete buffers on capture queue because it the one which
own the decoded buffers. After a dynamic resolution change lot of
them could remain allocated but won't be used anymore so deleting
them save memory.
Do not add this feature on output queue because the buffers are
smaller, fewer and always recycled even after a dynamic resolution
change.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
---
 drivers/media/platform/verisilicon/hantro_drv.c  | 1 +
 drivers/media/platform/verisilicon/hantro_v4l2.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/media/platform/verisilicon/hantro_drv.c
index db3df6cc4513..f6b0a676a740 100644
--- a/drivers/media/platform/verisilicon/hantro_drv.c
+++ b/drivers/media/platform/verisilicon/hantro_drv.c
@@ -248,6 +248,7 @@ queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq)
 	dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
 	dst_vq->lock = &ctx->dev->vpu_mutex;
 	dst_vq->dev = ctx->dev->v4l2_dev.dev;
+	src_vq->supports_delete_bufs = true;
 
 	return vb2_queue_init(dst_vq);
 }
diff --git a/drivers/media/platform/verisilicon/hantro_v4l2.c b/drivers/media/platform/verisilicon/hantro_v4l2.c
index 941fa23c211a..34eab90e8a42 100644
--- a/drivers/media/platform/verisilicon/hantro_v4l2.c
+++ b/drivers/media/platform/verisilicon/hantro_v4l2.c
@@ -756,6 +756,7 @@ const struct v4l2_ioctl_ops hantro_ioctl_ops = {
 	.vidioc_dqbuf = v4l2_m2m_ioctl_dqbuf,
 	.vidioc_prepare_buf = v4l2_m2m_ioctl_prepare_buf,
 	.vidioc_create_bufs = v4l2_m2m_ioctl_create_bufs,
+	.vidioc_delete_bufs = v4l2_m2m_ioctl_delete_bufs,
 	.vidioc_expbuf = v4l2_m2m_ioctl_expbuf,
 
 	.vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
-- 
2.40.1


  parent reply	other threads:[~2024-01-19  9:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19  9:49 [PATCH v17 0/8] Add DELETE_BUF ioctl Benjamin Gaignard
2024-01-19  9:49 ` [PATCH v17 1/8] videobuf2: Add min_reqbufs_allocation field to vb2_queue structure Benjamin Gaignard
2024-01-24 11:31   ` Hans Verkuil
2024-01-19  9:49 ` [PATCH v17 2/8] media: test-drivers: Set REQBUFS minimum number of buffers Benjamin Gaignard
2024-01-19  9:49 ` [PATCH v17 3/8] media: core: Rework how create_buf index returned value is computed Benjamin Gaignard
2024-01-24 11:20   ` Hans Verkuil
2024-01-19  9:49 ` [PATCH v17 4/8] media: core: Add bitmap manage bufs array entries Benjamin Gaignard
2024-01-24 11:52   ` Hans Verkuil
2024-01-19  9:49 ` [PATCH v17 5/8] media: core: Free range of buffers Benjamin Gaignard
2024-01-19  9:49 ` [PATCH v17 6/8] media: v4l2: Add DELETE_BUFS ioctl Benjamin Gaignard
2024-01-24 12:33   ` Hans Verkuil
2024-01-24 12:59     ` Hans Verkuil
2024-01-24 15:35     ` Benjamin Gaignard
2024-01-24 15:46       ` Hans Verkuil
2024-01-19  9:49 ` [PATCH v17 7/8] media: v4l2: Add mem2mem helpers for " Benjamin Gaignard
2024-01-19  9:49 ` Benjamin Gaignard [this message]
2024-01-24 12:52   ` [PATCH v17 8/8] media: verisilicon: Support deleting buffers on capture queue Hans Verkuil
2024-01-24 15:35     ` Benjamin Gaignard
2024-01-24 15:44       ` Hans Verkuil
2024-01-25  9:27         ` Benjamin Gaignard
2024-01-25  9:50           ` Hans Verkuil
2024-01-25 16:27       ` Nicolas Dufresne
2024-01-26  9:17         ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240119094944.26763-9-benjamin.gaignard@collabora.com \
    --to=benjamin.gaignard@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®