From: Armin Wolf <W_Armin@gmx.de>
To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] platform/x86: wmi: Use ACPI device name in netlink event
Date: Sun, 21 Jan 2024 21:08:24 +0100 [thread overview]
Message-ID: <20240121200824.2778-1-W_Armin@gmx.de> (raw)
The device name inside the ACPI netlink event is limited to
15 characters, so the WMI device name will get truncated.
This can be observed with kacpimon when receiving an event
from WMI device "9DBB5994-A997-11DA-B012-B622A1EF5492":
netlink: 9DBB5994-A997- 000000d0 00000000
Fix this by using the shorter device name from the ACPI
bus device instead. This still allows users to uniquely
identify the WMI device by using the notify id (0xd0).
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
Changes since v1:
- use acpi_dev_name() helper function
---
drivers/platform/x86/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index a7cfcbf92432..c61860db66ed 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -1202,7 +1202,7 @@ static int wmi_notify_device(struct device *dev, void *data)
}
acpi_bus_generate_netlink_event(wblock->acpi_device->pnp.device_class,
- dev_name(&wblock->dev.dev), *event, 0);
+ acpi_dev_name(wblock->acpi_device), *event, 0);
return -EBUSY;
}
--
2.39.2
next reply other threads:[~2024-01-21 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 20:08 Armin Wolf [this message]
2024-01-22 11:29 ` Hans de Goede
2024-01-22 12:47 ` Ilpo Järvinen
2024-01-22 15:03 ` Armin Wolf
2024-01-24 11:06 ` Hans de Goede
2024-01-24 11:10 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240121200824.2778-1-W_Armin@gmx.de \
--to=w_armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®