From: Rui Salvaterra <rsalvaterra@gmail.com>
To: amadeuszx.slawinski@linux.intel.com, tiwai@suse.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Rui Salvaterra <rsalvaterra@gmail.com>
Subject: [PATCH 2/2] ALSA: hda: Increase default bdl_pos_adj for Apollo Lake
Date: Mon, 22 Jan 2024 11:45:13 +0000 [thread overview]
Message-ID: <20240122114512.55808-3-rsalvaterra@gmail.com> (raw)
In-Reply-To: <20240122114512.55808-2-rsalvaterra@gmail.com>
Apollo Lake seems to also suffer from IRQ timing issues. After being up for ~4
minutes, a Pentium N4200 system ends up falling back to workqueue-based IRQ
handling:
[ 208.019906] snd_hda_intel 0000:00:0e.0: IRQ timing workaround is activated
for card #0. Suggest a bigger bdl_pos_adj.
Unfortunately, the Baytrail and Braswell workaround value of 32 samples isn't
enough to fix the issue here. Default to 64 samples.
Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
---
sound/pci/hda/hda_intel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 66f013ee160d..1b550c42db09 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1732,6 +1732,8 @@ static int default_bdl_pos_adj(struct azx *chip)
case PCI_DEVICE_ID_INTEL_HDA_BYT:
case PCI_DEVICE_ID_INTEL_HDA_BSW:
return 32;
+ case PCI_DEVICE_ID_INTEL_HDA_APL:
+ return 64;
}
}
--
2.43.0
next prev parent reply other threads:[~2024-01-22 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 11:45 [PATCH 1/2] ALSA: hda: Replace numeric device IDs with constant values Rui Salvaterra
2024-01-22 11:45 ` Rui Salvaterra [this message]
2024-01-22 11:51 ` [PATCH 2/2] ALSA: hda: Increase default bdl_pos_adj for Apollo Lake Amadeusz Sławiński
2024-01-22 11:51 ` [PATCH 1/2] ALSA: hda: Replace numeric device IDs with constant values Amadeusz Sławiński
2024-01-23 7:51 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122114512.55808-3-rsalvaterra@gmail.com \
--to=rsalvaterra@gmail.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®