From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Kuan-Wei Chiu <visitorckw@gmail.com>,
Stephen Boyd <sboyd@kernel.org>, Sasha Levin <sashal@kernel.org>,
mturquette@baylibre.com, dinguyen@kernel.org, heiko@sntech.de,
robh@kernel.org, krzysztof.kozlowski@linaro.org,
linux-clk@vger.kernel.org
Subject: [PATCH AUTOSEL 5.10 23/28] clk: hi3620: Fix memory leak in hi3620_mmc_clk_init()
Date: Mon, 22 Jan 2024 10:14:49 -0500 [thread overview]
Message-ID: <20240122151521.996443-23-sashal@kernel.org> (raw)
In-Reply-To: <20240122151521.996443-1-sashal@kernel.org>
From: Kuan-Wei Chiu <visitorckw@gmail.com>
[ Upstream commit bfbea9e5667cfa9552c3d88f023386f017f6c308 ]
In cases where kcalloc() fails for the 'clk_data->clks' allocation, the
code path does not handle the failure gracefully, potentially leading
to a memory leak. This fix ensures proper cleanup by freeing the
allocated memory for 'clk_data' before returning.
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Link: https://lore.kernel.org/r/20231210165040.3407545-1-visitorckw@gmail.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/clk/hisilicon/clk-hi3620.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/hisilicon/clk-hi3620.c b/drivers/clk/hisilicon/clk-hi3620.c
index a3d04c7c3da8..eb9c139babc3 100644
--- a/drivers/clk/hisilicon/clk-hi3620.c
+++ b/drivers/clk/hisilicon/clk-hi3620.c
@@ -467,8 +467,10 @@ static void __init hi3620_mmc_clk_init(struct device_node *node)
return;
clk_data->clks = kcalloc(num, sizeof(*clk_data->clks), GFP_KERNEL);
- if (!clk_data->clks)
+ if (!clk_data->clks) {
+ kfree(clk_data);
return;
+ }
for (i = 0; i < num; i++) {
struct hisi_mmc_clock *mmc_clk = &hi3620_mmc_clks[i];
--
2.43.0
next prev parent reply other threads:[~2024-01-22 15:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 15:14 [PATCH AUTOSEL 5.10 01/28] f2fs: fix to check return value of f2fs_reserve_new_block() Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 02/28] ALSA: hda: Refer to correct stream index at loops Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 03/28] ASoC: doc: Fix undefined SND_SOC_DAPM_NOPM argument Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 04/28] drm: Fix color LUT rounding Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 05/28] fast_dput(): handle underflows gracefully Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 06/28] RDMA/IPoIB: Fix error code return in ipoib_mcast_join Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 07/28] drm/amd/display: Fix tiled display misalignment Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 08/28] f2fs: fix write pointers on zoned device after roll forward Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 09/28] drm/amd/display: Fix writeback_info never got updated Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 10/28] drm/drm_file: fix use of uninitialized variable Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 11/28] drm/framebuffer: Fix " Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 12/28] drm/mipi-dsi: Fix detach call without attach Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 13/28] media: stk1160: Fixed high volume of stk1160_dbg messages Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 14/28] media: rockchip: rga: fix swizzling for RGB formats Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 15/28] PCI: add INTEL_HDA_ARL to pci_ids.h Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 16/28] ALSA: hda: Intel: add HDA_ARL PCI ID support Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 17/28] ALSA: hda: intel-dspcfg: add filters for ARL-S and ARL Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 18/28] hwmon: (pc87360) Bounds check data->innr usage Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 19/28] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 20/28] IB/ipoib: Fix mcast list locking Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 21/28] media: ddbridge: fix an error code problem in ddb_probe Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 22/28] drm/msm/dpu: Ratelimit framedone timeout msgs Sasha Levin
2024-01-22 15:14 ` Sasha Levin [this message]
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 24/28] clk: mmp: pxa168: Fix memory leak in pxa168_clk_init() Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 25/28] watchdog: it87_wdt: Keep WDTCTRL bit 3 unmodified for IT8784/IT8786 Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 26/28] drm/amd/display: make flip_timestamp_in_us a 64-bit variable Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 27/28] drm/amdgpu: Let KFD sync with VM fences Sasha Levin
2024-01-22 15:14 ` [PATCH AUTOSEL 5.10 28/28] drm/amdgpu: Drop 'fence' check in 'to_amdgpu_amdkfd_fence()' Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122151521.996443-23-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dinguyen@kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®