mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Dimitri Fedrau <dima.fedrau@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Stefan Eichenberger <eichest@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 net-next 10/13] net: phy: marvell-88q2xxx: make mv88q2xxx_config_aneg generic
Date: Mon, 22 Jan 2024 22:28:43 +0100	[thread overview]
Message-ID: <20240122212848.3645785-11-dima.fedrau@gmail.com> (raw)
In-Reply-To: <20240122212848.3645785-1-dima.fedrau@gmail.com>

Marvell 88Q2xxx devices follow the same scheme, after configuration they
need a soft reset. Soft resets differ between devices, so we use the
.soft_reset callback instead of creating .config_aneg callbacks for each
device.

Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
---
 drivers/net/phy/marvell-88q2xxx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/marvell-88q2xxx.c b/drivers/net/phy/marvell-88q2xxx.c
index f59822cf9526..8bd68b3c3ea1 100644
--- a/drivers/net/phy/marvell-88q2xxx.c
+++ b/drivers/net/phy/marvell-88q2xxx.c
@@ -362,7 +362,7 @@ static int mv88q2xxx_config_aneg(struct phy_device *phydev)
 	if (ret)
 		return ret;
 
-	return mv88q2xxx_soft_reset(phydev);
+	return phydev->drv->soft_reset(phydev);
 }
 
 static int mv88q2xxx_config_init(struct phy_device *phydev)
-- 
2.39.2


  parent reply	other threads:[~2024-01-22 21:30 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 21:28 [PATCH v5 net-next 00/13] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 01/13] net: phy: Add BaseT1 auto-negotiation constants Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 02/13] net: phy: Support 100/1000BT1 linkmode advertisements Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 03/13] net: phy: c45: detect 100/1000BASE-T1 " Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 04/13] net: phy: marvell-88q2xxx: fix typos Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 05/13] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Dimitri Fedrau
2024-01-31 15:08   ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 06/13] net: phy: marvell-88q2xxx: add interrupt support for link detection Dimitri Fedrau
2024-01-31 15:12   ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 07/13] net: phy: marvell-88q2xxx: add suspend / resume ops Dimitri Fedrau
2024-01-31 15:12   ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 08/13] net: phy: marvell-88q2xxx: add support for temperature sensor Dimitri Fedrau
2024-01-30  9:18   ` Russell King (Oracle)
2024-01-31 11:52     ` Dimitri Fedrau
2024-01-31 15:17   ` Andrew Lunn
2024-02-01  7:11     ` Dimitri Fedrau
2024-02-01 13:23       ` Andrew Lunn
2024-02-01 16:52         ` Dimitri Fedrau
2024-02-01 13:34       ` Guenter Roeck
2024-02-01 16:14         ` Dimitri Fedrau
2024-02-01 18:26           ` Guenter Roeck
2024-02-01 13:18   ` Guenter Roeck
2024-02-01 13:27     ` Andrew Lunn
2024-02-01 13:39       ` Guenter Roeck
2024-02-01 16:23         ` Dimitri Fedrau
2024-02-01 16:47           ` Andrew Lunn
2024-02-01 16:56             ` Dimitri Fedrau
2024-02-01 18:22           ` Guenter Roeck
2024-02-01 16:17     ` Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 09/13] net: phy: marvell-88q2xxx: add cable test support Dimitri Fedrau
2024-01-30  9:19   ` Russell King (Oracle)
2024-01-31 12:03     ` Dimitri Fedrau
2024-01-22 21:28 ` Dimitri Fedrau [this message]
2024-01-31 15:19   ` [PATCH v5 net-next 10/13] net: phy: marvell-88q2xxx: make mv88q2xxx_config_aneg generic Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 11/13] net: phy: marvell-88q2xxx: switch to mv88q2xxx_config_aneg Dimitri Fedrau
2024-01-31 15:20   ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 12/13] net: phy: marvell-88q2xxx: cleanup mv88q2xxx_config_init Dimitri Fedrau
2024-01-31 15:21   ` Andrew Lunn
2024-02-02 17:19     ` Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 13/13] net: phy: marvell-88q2xxx: remove redundant code Dimitri Fedrau
2024-01-30  2:09 ` [PATCH v5 net-next 00/13] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Jakub Kicinski
2024-02-02 18:30   ` Dimitri Fedrau
2024-02-03 16:07     ` Andrew Lunn
2024-02-05  9:32       ` Dimitri Fedrau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240122212848.3645785-11-dima.fedrau@gmail.com \
    --to=dima.fedrau@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eichest@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome