From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Miklos Szeredi <miklos@szeredi.hu>,
Stefan Hajnoczi <stefanha@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: [PATCH] virtiofs: avoid unnecessary VM_MIXEDMAP for mmap support
Date: Tue, 23 Jan 2024 18:58:03 +0800 [thread overview]
Message-ID: <20240123105803.1725795-1-hsiangkao@linux.alibaba.com> (raw)
After commit e1fb4a0864958 ("dax: remove VM_MIXEDMAP for fsdax and
device dax"), VM_MIXEDMAP seems unnecessary for virtiofs DAX mapping
(devmap).
At least I'm not sure why VM_MIXEDMAP is used during some internal
review (I guess that was added due to the current DAX documentation),
it could avoid copying page table when forking since page faults could
fill DAX VMAs just fine.
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
fs/fuse/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c
index 12ef91d170bb..5a3c17a80340 100644
--- a/fs/fuse/dax.c
+++ b/fs/fuse/dax.c
@@ -858,7 +858,7 @@ int fuse_dax_mmap(struct file *file, struct vm_area_struct *vma)
{
file_accessed(file);
vma->vm_ops = &fuse_dax_vm_ops;
- vm_flags_set(vma, VM_MIXEDMAP | VM_HUGEPAGE);
+ vm_flags_set(vma, VM_HUGEPAGE);
return 0;
}
--
2.39.3
reply other threads:[~2024-01-23 10:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123105803.1725795-1-hsiangkao@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®