From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 165587F7D9 for ; Wed, 24 Jan 2024 18:22:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706120540; cv=none; b=VKMSzL/Ita4rqsBiTm0w6IXL7tqWkBn1n/x9BJ7txtgQpLSuP0Rz37HhlX1BvOgGPwPsbg1ubIwrbWoUPCmix7HmKNJYWao/dJtKdnGtKAtYks61KA7CAEB1Y3v8hjUbWEI78wh/rc3tXBrcHeYhxS1Xy/Odus2VYDI6FI1tn0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706120540; c=relaxed/simple; bh=wbZWmGrWH8JcJ771piCTg/bWVpmwahSuzv7Z+Mj+J1k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U6U0e5pQ4VQP2YVGONJSL8yVpl2u+7KuT5rU/gT1qQ8216qmdRK5X6s76Lefjk9cxoGR+mliDajvHc85aFuf55tuBbKSTmgEq6iqCFtKqcaxISQG9MgAf4MFQozxBIfzkwrBtZqAwlWkfEI9WW4CDf/OF9uQUKiaOOa7Y6hHRpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Y21U/Jzy; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y21U/Jzy" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-337d90030bfso5056256f8f.2 for ; Wed, 24 Jan 2024 10:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706120537; x=1706725337; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pnIYdN+laIAJSsus1mByKQQs+4v4u+0ydG/KXxGrtlA=; b=Y21U/JzyBLQRL1nCHZW5/jA/X2nh1EqyrqXEd9iivneEjsIQ+76eO7Yj1Qnh8WN1SJ /EGXnCDwg41+om+vv9X/aSQDEjkp8Xzv+n7tgvWqAsH4pWr0JkD4X/Z6WiH1v+5rMNog B8yb9RERpZzRNdFHuI3pHLZfMH3Vtc/RYIobxZ3Rzc+Nd5TkTlq34C2YurtyRYY7m/cD SReIz0ynLQMdSbjsUcfGuKg30+TGzbSlTYNZl4Knsq09O4gIv3ruY15jMwsu1yyqHHMk /ZyO+A6fIT4Ar2rcN8V3POsSoYbRaSDQjRDiSkqGPINkwdAhSO5EmslCkkwgK9tO/MDy EGkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706120537; x=1706725337; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pnIYdN+laIAJSsus1mByKQQs+4v4u+0ydG/KXxGrtlA=; b=AEJwL6c0n0BzsgJLaqqXnlD7P5OZYhS3uRhYpOTTgSBAAlrBrJegLRcz6rR2gxNzhJ E4xxQM2trZyV/ets/cFFCvsqPnrqJTsM2Z15Ha0UAIDOam4C3Lu6XgRiVV9QMybrlrRg P17IGlMYJfAsBZ+ZJW95EsPEFm1/bmwLS+sj/T90bD9kiefUW4hvepnoTGQB0mG5qO1M RAfu6hb/bwiIOzgSdWnnzUYr9aO9Dba1o29h81srmGiQnWk3D45d/muBypYJqF/z32wx biTPzc1FwgAUDI1pq2HIOVlzhDnpIB8Q0lOgTXZCdDImZUQBhMwumRLatMtaY4G8gc4k FRpg== X-Gm-Message-State: AOJu0YxM3iwEAdtHRBF8sdZVC+nUiy7fhxeZBwC5CdAmA/6anfK3Rz9v HR6cHeKOc34wbro2duT2JQ2Ua8loQGc5ei2HU1drNlwZzgPjNhXa9OzJE003tNY= X-Google-Smtp-Source: AGHT+IHRmPShxmMLc/LTRITs/dmQsYbYRl3PA6qkdxRGGoc4nhXoojgy4gjjuy51N7s47SgWWFbo9g== X-Received: by 2002:adf:f5c6:0:b0:337:cd6a:2952 with SMTP id k6-20020adff5c6000000b00337cd6a2952mr388281wrp.245.1706120537342; Wed, 24 Jan 2024 10:22:17 -0800 (PST) Received: from myrica ([2.221.137.100]) by smtp.gmail.com with ESMTPSA id w14-20020a5d404e000000b00337d9a717bcsm14779739wrp.52.2024.01.24.10.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 10:22:16 -0800 (PST) Date: Wed, 24 Jan 2024 18:22:23 +0000 From: Jean-Philippe Brucker To: Suzuki K Poulose Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Feng Liu , "Michael S . Tsirkin" , Yishai Hadas , Alex Williamson Subject: Re: [PATCH] virtio: uapi: Drop __packed attribute in linux/virtio_pci.h: Message-ID: <20240124182223.GA3941090@myrica> References: <20240124172345.853129-1-suzuki.poulose@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240124172345.853129-1-suzuki.poulose@arm.com> On Wed, Jan 24, 2024 at 05:23:45PM +0000, Suzuki K Poulose wrote: > Commit 92792ac752aa ("virtio-pci: Introduce admin command sending function") > added "__packed" structures to UAPI header linux/virtio_pci.h. This triggers > build failures in the consumer userspace applications without proper "definition" > of __packed (e.g., kvmtool build fails). > > Moreover, the structures are already packed well, and doesn't need explicit > packing, similar to the rest of the structures in all virtio_* headers. Remove > the __packed attribute. > > Fixes: commit 92792ac752aa ("virtio-pci: Introduce admin command sending function") > Cc: Feng Liu > Cc: Michael S. Tsirkin > Cc: Yishai Hadas > Cc: Alex Williamson > Cc: Jean-Philippe Brucker > Signed-off-by: Suzuki K Poulose Reviewed-by: Jean-Philippe Brucker > --- > include/uapi/linux/virtio_pci.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > index ef3810dee7ef..a8208492e822 100644 > --- a/include/uapi/linux/virtio_pci.h > +++ b/include/uapi/linux/virtio_pci.h > @@ -240,7 +240,7 @@ struct virtio_pci_cfg_cap { > #define VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ 0x5 > #define VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_INFO 0x6 > > -struct __packed virtio_admin_cmd_hdr { > +struct virtio_admin_cmd_hdr { > __le16 opcode; > /* > * 1 - SR-IOV > @@ -252,20 +252,20 @@ struct __packed virtio_admin_cmd_hdr { > __le64 group_member_id; > }; > > -struct __packed virtio_admin_cmd_status { > +struct virtio_admin_cmd_status { > __le16 status; > __le16 status_qualifier; > /* Unused, reserved for future extensions. */ > __u8 reserved2[4]; > }; > > -struct __packed virtio_admin_cmd_legacy_wr_data { > +struct virtio_admin_cmd_legacy_wr_data { > __u8 offset; /* Starting offset of the register(s) to write. */ > __u8 reserved[7]; > __u8 registers[]; > }; > > -struct __packed virtio_admin_cmd_legacy_rd_data { > +struct virtio_admin_cmd_legacy_rd_data { > __u8 offset; /* Starting offset of the register(s) to read. */ > }; > > @@ -275,7 +275,7 @@ struct __packed virtio_admin_cmd_legacy_rd_data { > > #define VIRTIO_ADMIN_CMD_MAX_NOTIFY_INFO 4 > > -struct __packed virtio_admin_cmd_notify_info_data { > +struct virtio_admin_cmd_notify_info_data { > __u8 flags; /* 0 = end of list, 1 = owner device, 2 = member device */ > __u8 bar; /* BAR of the member or the owner device */ > __u8 padding[6]; > -- > 2.34.1 >