From: Conor Dooley <conor@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: thermal-zones: Don't require polling-delay(-passive)
Date: Thu, 25 Jan 2024 16:51:11 +0000 [thread overview]
Message-ID: <20240125-wildfowl-confined-25c6b276cdcb@spud> (raw)
In-Reply-To: <20240125-topic-thermal-v1-1-3c9d4dced138@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]
On Thu, Jan 25, 2024 at 01:11:15PM +0100, Konrad Dybcio wrote:
> Currently, thermal zones associated with providers that have interrupts
> for signaling hot/critical trips are required to set a polling-delay
> of 0 to indicate no polling. This feels a bit backwards.
>
> Assume 0 (no polling) when these properties are not defined.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
I think that makes sense.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/thermal/thermal-zones.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> index dbd52620d293..68398e7e8655 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> +++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> @@ -228,8 +228,6 @@ patternProperties:
> additionalProperties: false
>
> required:
> - - polling-delay
> - - polling-delay-passive
> - thermal-sensors
> - trips
>
>
> --
> 2.40.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-01-25 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 12:11 [PATCH 0/2] Assume polling-delay(-passive) = 0 when absent Konrad Dybcio
2024-01-25 12:11 ` [PATCH 1/2] dt-bindings: thermal-zones: Don't require polling-delay(-passive) Konrad Dybcio
2024-01-25 16:51 ` Conor Dooley [this message]
2024-02-02 4:19 ` Bjorn Andersson
2024-01-25 12:11 ` [PATCH 2/2] thermal/of: Assume polling-delay(-passive) 0 when absent Konrad Dybcio
2024-02-02 4:19 ` Bjorn Andersson
2024-03-07 8:04 ` Dmitry Baryshkov
2024-03-07 9:36 ` [PATCH 0/2] Assume polling-delay(-passive) = " Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125-wildfowl-confined-25c6b276cdcb@spud \
--to=conor@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®