From: Michael Tretter <m.tretter@pengutronix.de>
To: Bo Liu <liubo03@inspur.com>
Cc: kernel@pengutronix.de, mchehab@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: isl7998x: convert to use maple tree register cache
Date: Thu, 25 Jan 2024 09:43:02 +0100 [thread overview]
Message-ID: <20240125084302.GA383229@pengutronix.de> (raw)
In-Reply-To: <20240117030910.2790-1-liubo03@inspur.com>
On Tue, 16 Jan 2024 22:09:10 -0500, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> drivers/media/i2c/isl7998x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/isl7998x.c b/drivers/media/i2c/isl7998x.c
> index 89e13ebbce0c..c7089035bbc1 100644
> --- a/drivers/media/i2c/isl7998x.c
> +++ b/drivers/media/i2c/isl7998x.c
> @@ -1337,7 +1337,7 @@ static const struct regmap_config isl7998x_regmap = {
> .rd_table = &isl7998x_readable_table,
> .wr_table = &isl7998x_writeable_table,
> .volatile_table = &isl7998x_volatile_table,
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
> };
>
> static int isl7998x_mc_init(struct isl7998x *isl7998x)
> --
> 2.31.1
>
>
prev parent reply other threads:[~2024-01-25 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 3:09 Bo Liu
2024-01-25 8:43 ` Michael Tretter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125084302.GA383229@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=liubo03@inspur.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®