From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, quic_cang@quicinc.com,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Conor Dooley <conor.dooley@microchip.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v3 00/17] Fix Qcom UFS PHY clocks
Date: Wed, 31 Jan 2024 12:37:23 +0530 [thread overview]
Message-ID: <20240131-ufs-phy-clock-v3-0-58a49d2f4605@linaro.org> (raw)
Hi,
This series fixes the clocks supplied to QMP PHY IPs in the Qcom SoCs. All
of the Qcom SoCs except MSM8996 require 3 clocks for QMP UFS:
* ref - 19.2MHz reference clock from RPM/RPMh
* ref_aux - Auxiliary reference clock from GCC
* qref - QREF clock from GCC or TCSR (TCSR since SM8550)
MSM8996 only requires 'ref' and 'qref' clocks.
Hence, this series fixes the binding, DT and GCC driver to reflect the
actual clock topology.
Note that the clock topology is not based on any downstream dts sources (even
they are not accurate). But rather based on information from Qcom internal
documentation and brain dump from Can Guo.
Testing
=======
Tested on Qualcomm RB5 development board based on SM8250 SoC. I don't
expect this series to break other SoCs too.
- Mani
Changes in v3:
* Added a patch for SM8650
* Collected review tags
* Rebased on top of next/20231123
Changes in v2:
* Reworded the commit message of patch 1 to justify ABI breakage
* Collected review tags
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
Manivannan Sadhasivam (17):
dt-bindings: phy: qmp-ufs: Fix PHY clocks
phy: qcom-qmp-ufs: Switch to devm_clk_bulk_get_all() API
dt-bindings: clock: qcom: Add missing UFS QREF clocks
clk: qcom: gcc-sc8180x: Add missing UFS QREF clocks
arm64: dts: qcom: msm8996: Fix UFS PHY clocks
arm64: dts: qcom: msm8998: Fix UFS PHY clocks
arm64: dts: qcom: sdm845: Fix UFS PHY clocks
arm64: dts: qcom: sm6115: Fix UFS PHY clocks
arm64: dts: qcom: sm6125: Fix UFS PHY clocks
arm64: dts: qcom: sm6350: Fix UFS PHY clocks
arm64: dts: qcom: sm8150: Fix UFS PHY clocks
arm64: dts: qcom: sm8250: Fix UFS PHY clocks
arm64: dts: qcom: sc8180x: Fix UFS PHY clocks
arm64: dts: qcom: sc8280xp: Fix UFS PHY clocks
arm64: dts: qcom: sm8350: Fix UFS PHY clocks
arm64: dts: qcom: sm8550: Fix UFS PHY clocks
arm64: dts: qcom: sm8650: Fix UFS PHY clocks
.../bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 48 ++++++++---------
arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 +-
arch/arm64/boot/dts/qcom/msm8998.dtsi | 12 ++---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 ++-
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 18 ++++---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 +--
arch/arm64/boot/dts/qcom/sm6115.dtsi | 8 ++-
arch/arm64/boot/dts/qcom/sm6125.dtsi | 8 +--
arch/arm64/boot/dts/qcom/sm6350.dtsi | 8 +--
arch/arm64/boot/dts/qcom/sm8150.dtsi | 8 +--
arch/arm64/boot/dts/qcom/sm8250.dtsi | 8 +--
arch/arm64/boot/dts/qcom/sm8350.dtsi | 8 +--
arch/arm64/boot/dts/qcom/sm8550.dtsi | 9 ++--
arch/arm64/boot/dts/qcom/sm8650.dtsi | 8 +--
drivers/clk/qcom/gcc-sc8180x.c | 28 ++++++++++
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 63 +++-------------------
include/dt-bindings/clock/qcom,gcc-sc8180x.h | 2 +
17 files changed, 129 insertions(+), 125 deletions(-)
---
base-commit: 06f658aadff0e483ee4f807b0b46c9e5cba62bfa
change-id: 20240131-ufs-phy-clock-7939b9258b3c
Best regards,
--
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
next reply other threads:[~2024-01-31 7:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 7:07 Manivannan Sadhasivam [this message]
2024-01-31 7:07 ` [PATCH v3 01/17] dt-bindings: phy: qmp-ufs: Fix " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 02/17] phy: qcom-qmp-ufs: Switch to devm_clk_bulk_get_all() API Manivannan Sadhasivam
2024-01-31 7:16 ` Dmitry Baryshkov
2024-02-01 19:16 ` Konrad Dybcio
2024-01-31 7:07 ` [PATCH v3 03/17] dt-bindings: clock: qcom: Add missing UFS QREF clocks Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 04/17] clk: qcom: gcc-sc8180x: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 05/17] arm64: dts: qcom: msm8996: Fix UFS PHY clocks Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 06/17] arm64: dts: qcom: msm8998: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 07/17] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 08/17] arm64: dts: qcom: sm6115: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 09/17] arm64: dts: qcom: sm6125: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 10/17] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 11/17] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 12/17] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 13/17] arm64: dts: qcom: sc8180x: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 14/17] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 15/17] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 16/17] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
2024-01-31 7:07 ` [PATCH v3 17/17] arm64: dts: qcom: sm8650: " Manivannan Sadhasivam
2024-02-01 19:17 ` Konrad Dybcio
2024-02-07 4:46 ` (subset) [PATCH v3 00/17] Fix Qcom " Bjorn Andersson
2024-02-07 14:01 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131-ufs-phy-clock-v3-0-58a49d2f4605@linaro.org \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=quic_cang@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®