From: Peter Hilber <peter.hilber@opensynergy.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Hilber <peter.hilber@opensynergy.com>,
"D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
jstultz@google.com, giometti@enneenne.com, corbet@lwn.net, "Dong,
Eddie" <eddie.dong@intel.com>,
"Hall, Christopher S" <christopher.s.hall@intel.com>,
Simon Horman <horms@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marc Zyngier <maz@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Wanpeng Li <wanpengli@tencent.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Richard Cochran <richardcochran@gmail.com>,
kvm@vger.kernel.org, netdev@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>
Subject: [PATCH v3 2/8] timekeeping: Add clocksource ID to struct system_counterval_t
Date: Thu, 1 Feb 2024 02:04:47 +0100 [thread overview]
Message-ID: <20240201010453.2212371-3-peter.hilber@opensynergy.com> (raw)
In-Reply-To: <20240201010453.2212371-1-peter.hilber@opensynergy.com>
Clocksource pointers can be problematic to obtain for drivers which are not
clocksource drivers themselves. In particular, the RFC virtio_rtc driver
[1] would require a new helper function to obtain a pointer to the Arm
Generic Timer clocksource. The ptp_kvm driver also required a similar
workaround.
Add a clocksource ID member to struct system_counterval_t, which in the
future shall identify the clocksource, and which shall replace the struct
clocksource * member. By this, get_device_system_crosststamp() callers
(such as virtio_rtc and ptp_kvm) will be able to supply easily accessible
clocksource ids instead of clocksource pointers.
[1] https://lore.kernel.org/lkml/20231218073849.35294-1-peter.hilber@opensynergy.com/
Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com>
---
Notes:
v2:
- Refer to clocksource IDs as such in comments (Thomas Gleixner).
include/linux/timekeeping.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h
index 7c43e98cf211..ca234fa4cc04 100644
--- a/include/linux/timekeeping.h
+++ b/include/linux/timekeeping.h
@@ -273,10 +273,15 @@ struct system_device_crosststamp {
* @cycles: System counter value
* @cs: Clocksource corresponding to system counter value. Used by
* timekeeping code to verify comparibility of two cycle values
+ * @cs_id: Clocksource ID corresponding to system counter value. To be
+ * used instead of cs in the future.
+ * The default ID, CSID_GENERIC, does not identify a specific
+ * clocksource.
*/
struct system_counterval_t {
u64 cycles;
struct clocksource *cs;
+ enum clocksource_ids cs_id;
};
/*
--
2.40.1
next prev parent reply other threads:[~2024-02-01 1:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 1:04 [PATCH v3 0/8] treewide: Use clocksource ID for get_device_system_crosststamp() Peter Hilber
2024-02-01 1:04 ` [PATCH v3 1/8] x86/tsc: Fix major kernel-doc warnings for tsc.c Peter Hilber
2024-02-01 4:52 ` Randy Dunlap
2024-02-06 10:54 ` Peter Hilber
2024-02-06 20:34 ` Randy Dunlap
2024-02-01 1:04 ` Peter Hilber [this message]
2024-02-11 8:41 ` [tip: timers/ptp] timekeeping: Add clocksource ID to struct system_counterval_t tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 3/8] x86/tsc: Add clocksource ID, set system_counterval_t.cs_id Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 4/8] x86/kvm, ptp/kvm: " Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 5/8] ptp/kvm, arm_arch_timer: Set system_counterval_t.cs_id to constant Peter Hilber
2024-02-01 13:52 ` Marc Zyngier
2024-02-01 14:04 ` Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 6/8] timekeeping: Evaluate system_counterval_t.cs_id instead of .cs Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 7/8] treewide: Remove system_counterval_t.cs, which is never read Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
2024-02-01 1:04 ` [PATCH v3 8/8] kvmclock: Unexport kvmclock clocksource Peter Hilber
2024-02-11 8:41 ` [tip: timers/ptp] " tip-bot2 for Peter Hilber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201010453.2212371-3-peter.hilber@opensynergy.com \
--to=peter.hilber@opensynergy.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=christopher.s.hall@intel.com \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=eddie.dong@intel.com \
--cc=giometti@enneenne.com \
--cc=horms@kernel.org \
--cc=hpa@zytor.com \
--cc=jstultz@google.com \
--cc=kvm@vger.kernel.org \
--cc=lakshmi.sowjanya.d@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sboyd@kernel.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®