mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	 Tycho Andersen <tycho@tycho.pizza>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] pidfd: implement PIDFD_THREAD flag for pidfd_open()
Date: Fri, 2 Feb 2024 13:50:25 +0100	[thread overview]
Message-ID: <20240202-helium-eurem-f63c0f9328c0@brauner> (raw)
In-Reply-To: <20240131132602.GA23641@redhat.com>

> @@ -2050,6 +2051,8 @@ static void pidfd_show_fdinfo(struct seq_file *m, struct file *f)
>  
>  	seq_put_decimal_ll(m, "Pid:\t", nr);
>  
> +	/* TODO: report PIDFD_THREAD */

So I think we don't need to do anything here. Since PIDFD_THREAD sets
O_EXCL in file->f_flags and in contrast to do_dentry_open() it isn't
dropped. So userspace can already detect PIDFD_NONBLOCK as O_NONBLOCK
and PIDFD_THREAD as O_EXCL.

  parent reply	other threads:[~2024-02-02 12:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 13:25 [PATCH v3 0/1] " Oleg Nesterov
2024-01-31 13:26 ` [PATCH v3 1/1] " Oleg Nesterov
2024-01-31 14:12   ` Christian Brauner
2024-01-31 14:19     ` Oleg Nesterov
2024-01-31 17:23   ` Tycho Andersen
2024-01-31 18:01     ` Oleg Nesterov
2024-01-31 18:15       ` Christian Brauner
2024-02-01 17:25   ` Christian Brauner
2024-02-01 18:10     ` Oleg Nesterov
2024-02-02 12:50   ` Christian Brauner [this message]
2024-02-05 15:22     ` Oleg Nesterov
2024-02-06 13:38       ` Christian Brauner
2024-02-08  7:54   ` kernel test robot
2024-02-08  8:58     ` Christian Brauner
2024-02-08  9:18       ` Oleg Nesterov
2024-01-31 13:58 ` [PATCH v3 0/1] " Christian Brauner
2024-01-31 14:12 ` Oleg Nesterov
2024-01-31 14:39   ` Christian Brauner
2024-01-31 16:10     ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240202-helium-eurem-f63c0f9328c0@brauner \
    --to=brauner@kernel.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=tycho@tycho.pizza \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®