From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, akpm@linuxfoundation.org
Cc: joe@perches.com, Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 2/2] checkpatch: minor whitespace changes for readability
Date: Sat, 3 Feb 2024 12:55:27 -0700 [thread overview]
Message-ID: <20240203195527.212505-3-jim.cromie@gmail.com> (raw)
In-Reply-To: <20240203195527.212505-1-jim.cromie@gmail.com>
Change the per-patch report format slightly, so its more paragraphic,
and easier to peruse/scan.
OLD FORM:
0001-checkpatch-report last line, looks part of 0002 has no ...
--------------------------------------------------------------
0002-checkpatch-minor-whitespace-changes-for-readability.patch
--------------------------------------------------------------
total: 0 errors, 0 warnings, 15 lines checked
0002-checkpatch-minor-whitespace-changes-for-readability.patch has no ...
--------------------------------------------------------------
NEW FORM:
--------------------------------------------------------------
0002-checkpatch-minor-whitespace-changes-for-readability.patch
--------------------------------------------------------------
total: 0 errors, 0 warnings, 15 lines checked
0002-checkpatch-minor-whitespace-changes-for-readability.patch
has no obvious style problems and is ready for submission.
--------------------------------------------------------------
For the optimum (warning free) patchset, the new report format is a
series of single paragraphs (with the --- banners), one for each patch
in the series. This is trivial to scan/peruse, and is also more
visually distinct from warning/error reports.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
scripts/checkpatch.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index dc17c6da3af2..cd249ae9abdd 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -7796,12 +7796,12 @@ EOM
}
if ($quiet == 0) {
- print "\n";
if ($clean == 1) {
- print "$vname has no obvious style problems and is ready for submission.\n";
+ print "$vname \n has no obvious style problems and is ready for submission.\n";
} else {
- print "$vname has style problems, please review.\n";
+ print "$vname \n has style problems, please review.\n";
}
+ print "\n";
}
return $clean;
}
--
2.43.0
next prev parent reply other threads:[~2024-02-03 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 19:55 [PATCH 0/2] checkpatch: relax >75 warning, adjust report format Jim Cromie
2024-02-03 19:55 ` [PATCH 1/2] checkpatch: tolerate long lines w/o spaces Jim Cromie
2024-02-05 18:02 ` Joe Perches
2024-02-03 19:55 ` Jim Cromie [this message]
2024-02-05 17:38 ` [PATCH 2/2] checkpatch: minor whitespace changes for readability Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240203195527.212505-3-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=akpm@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®