From: Dhruva Gole <d-gole@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Théo Lebrun" <theo.lebrun@bootlin.com>,
"Apurva Nandan" <a-nandan@ti.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH v2 2/4] spi: cadence-qspi: fix pointer reference in runtime PM hooks
Date: Wed, 7 Feb 2024 14:09:02 +0530 [thread overview]
Message-ID: <20240207083902.mzkcsqf3tbwkkxd2@dhruva> (raw)
In-Reply-To: <ZcD6yqc+o62x2AjA@finisterre.sirena.org.uk>
Hi Mark,
On Feb 05, 2024 at 15:12:10 +0000, Mark Brown wrote:
> On Mon, Feb 05, 2024 at 03:57:30PM +0100, Théo Lebrun wrote:
> > dev_get_drvdata() gets used to acquire the pointer to cqspi and the SPI
> > controller. Neither embed the other; this lead to memory corruption.
> >
> > On a given platform (Mobileye EyeQ5) the memory corruption is hidden
> > inside cqspi->f_pdata. Also, this uninitialised memory is used as a
> > mutex (ctlr->bus_lock_mutex) by spi_controller_suspend().
>
> Please place fixes at the start of serieses so that they don't end up
> with spurious dependencies on other changes and can more easily be
> applied as fixes.
Didn't really understand the comment here, aren't the 1,2 and 3 patches
fixes and the last one the non-fix? Thus fixes are indeed placed at
start of this series right?
Can you help understand with some example series?
--
Best regards,
Dhruva Gole <d-gole@ti.com>
next prev parent reply other threads:[~2024-02-07 8:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 14:57 [PATCH v2 0/4] spi: cadence-qspi: Fix runtime PM and system-wide suspend Théo Lebrun
2024-02-05 14:57 ` [PATCH v2 1/4] spi: cadence-qspi: put runtime in runtime PM hooks names Théo Lebrun
2024-02-07 8:33 ` Dhruva Gole
2024-02-07 9:25 ` Théo Lebrun
2024-02-05 14:57 ` [PATCH v2 2/4] spi: cadence-qspi: fix pointer reference in runtime PM hooks Théo Lebrun
2024-02-05 15:12 ` Mark Brown
2024-02-07 8:39 ` Dhruva Gole [this message]
2024-02-07 9:50 ` Mark Brown
2024-02-07 10:14 ` Dhruva Gole
2024-02-07 8:42 ` Dhruva Gole
2024-02-07 9:28 ` Théo Lebrun
2024-02-07 10:12 ` Dhruva Gole
2024-02-05 14:57 ` [PATCH v2 3/4] spi: cadence-qspi: remove system-wide suspend helper calls from " Théo Lebrun
2024-02-05 14:57 ` [PATCH v2 4/4] spi: cadence-qspi: add system-wide suspend and resume callbacks Théo Lebrun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207083902.mzkcsqf3tbwkkxd2@dhruva \
--to=d-gole@ti.com \
--cc=a-nandan@ti.com \
--cc=broonie@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®