From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE6921CD25 for ; Thu, 8 Feb 2024 02:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707357670; cv=none; b=g8sOwJZS4kolT8FKMKfrrlKUpYpbKDFVJB4Oo8uehQ9KjEi/dbmRvX0saJQiDwHZiLhIj/G2DsJ8p1obxclB3cVq9rEM5Eb2cJgH0esXJRZJ6vrshsvy1cg/houGwV8jJGvUFb5kVAU0rZRgzZprG3285veT0057d1PYTyjukgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707357670; c=relaxed/simple; bh=dwTLQzI/QIkNCUaRNzVuPjQwBg8dpqhsrkwPkL+Pg7g=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=COvwQ0U9faWyYketnoJ4LbhNKaAO8lN2Azt74mHqvAt0ggZDWiIyv0Mf1eDZ172k/Bqdvil5imgYH55b/4q/GzRKv+ZrFNbJ3IUMi2nXe0QR75cPxfOScYrj6OqLZQnbH2ZdAIMUd5ld5ZHbMIcLHvvqHZgtBO7tu9sKTqGVTQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=ry4rv5Zd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="ry4rv5Zd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D66AC433C7; Thu, 8 Feb 2024 02:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707357669; bh=dwTLQzI/QIkNCUaRNzVuPjQwBg8dpqhsrkwPkL+Pg7g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ry4rv5ZdjcSuqtYio8CxxKNPfgBtQ5SZk14HB7hm+WwWdBn0VomqE2FLHV9pJojq9 7bphmEJCiWzntJPdMCabGqgE5OIjyDA+Asw8BlDH+VBUug0L21dFZB8Td+ftMMacMg Rle8uVDEKFFELCeYg9jOthphVF05BW7aUP2lhqa8= Date: Wed, 7 Feb 2024 18:01:08 -0800 From: Andrew Morton To: Muchun Song Cc: Prakash Sangappa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, mike.kravetz@oracle.com Subject: Re: [PATCH v3] Hugetlb pages should not be reserved by shmat() if SHM_NORESERVE Message-Id: <20240207180108.6a181d9fa5b404f78c0b4b22@linux-foundation.org> In-Reply-To: References: <1706040282-12388-1-git-send-email-prakash.sangappa@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Jan 2024 15:03:15 +0800 Muchun Song wrote: > > Fix is to ensure that hugetlb pages are not reserved for SHM_HUGETLB shared > > memory in the shmat() call. > > Signed-off-by: Prakash Sangappa > > BTW, it is better to add a Fixes tag to specify which commit > that this commit aims to fix. s/better/essential/ However this issue appears to pass the "been there forever" test, so I'll send it to Linus as-is.