mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
	Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH 03/14] crypto: ecdsa - Adjust res.x mod n for NIST P521
Date: Thu,  8 Feb 2024 17:18:29 -0500	[thread overview]
Message-ID: <20240208221840.3665874-4-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20240208221840.3665874-1-stefanb@linux.ibm.com>

When res.x >= n then res.x mod n can be calculated by iteratively sub-
tracting n from res.x until n > res.x. For NIST P192/256/384 this is done
in a single subtraction since these curves' 'n' use all the 64bit digits.
This is also significantly faster than a modulo operation. For NIST P521
the same could take multiple subtractions. However, during testing with
varying NIST P521 keys it was never necessary to do any subtraction at all.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
 crypto/ecdsa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/ecdsa.c b/crypto/ecdsa.c
index 228f675ac2ed..c9b867a9cbb9 100644
--- a/crypto/ecdsa.c
+++ b/crypto/ecdsa.c
@@ -121,8 +121,8 @@ static int _ecdsa_verify(struct ecc_ctx *ctx, const u64 *hash, const u64 *r, con
 	ecc_point_mult_shamir(&res, u1, &curve->g, u2, &ctx->pub_key, curve);
 
 	/* res.x = res.x mod n (if res.x > order) */
-	if (unlikely(vli_cmp(res.x, curve->n, ndigits) == 1))
-		/* faster alternative for NIST p384, p256 & p192 */
+	while (unlikely(vli_cmp(res.x, curve->n, ndigits) == 1))
+		/* faster alternative for NIST p521, p384, p256 & p192 */
 		vli_sub(res.x, res.x, curve->n, ndigits);
 
 	if (!vli_cmp(res.x, r, ndigits))
-- 
2.43.0


  parent reply	other threads:[~2024-02-08 22:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08 22:18 [PATCH 00/14] Add support for NIST P521 to ecdsa and ecdh Stefan Berger
2024-02-08 22:18 ` [PATCH 01/14] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-02-09 19:36   ` kernel test robot
2024-02-08 22:18 ` [PATCH 02/14] crypto: ecdsa - Adjust tests on length of key material Stefan Berger
2024-02-08 22:18 ` Stefan Berger [this message]
2024-02-08 22:18 ` [PATCH 04/14] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-02-08 22:18 ` [PATCH 05/14] crypto: ecc - For NIST P521 use vli_num_bits to get number of bits Stefan Berger
2024-02-08 22:18 ` [PATCH 06/14] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-02-08 22:18 ` [PATCH 07/14] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-02-08 22:18 ` [PATCH 08/14] x509: Add OID for NIST P521 and extend parser for it Stefan Berger
2024-02-08 22:18 ` [PATCH 09/14] crypto: ecdh - Use properly formatted digits to check for valid key Stefan Berger
2024-02-08 22:18 ` [PATCH 10/14] crypto: ecc - Implement ecc_digits_to_array to convert digits to byte array Stefan Berger
2024-02-08 22:18 ` [PATCH 11/14] crypto: Add nbits field to ecc_curve structure Stefan Berger
2024-02-08 22:18 ` [PATCH 12/14] crypto: ecc - Implement and use ecc_curve_get_nbytes to get curve's nbytes Stefan Berger
2024-02-08 22:18 ` [PATCH 13/14] crypto: ecdh - Use functions to copy digits from and to array Stefan Berger
2024-02-08 22:18 ` [PATCH 14/14] crypto: ecdh - Add support for NIST P521 and add test case Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240208221840.3665874-4-stefanb@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saulo.alessandre@tse.jus.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®