From: Costa Shulyupin <costa.shul@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Cc: Costa Shulyupin <costa.shul@redhat.com>,
Waiman Long <longman@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>
Subject: [PATCH v2] hrtimer: select housekeeping CPU during migration
Date: Tue, 13 Feb 2024 18:46:51 +0200 [thread overview]
Message-ID: <20240213164650.2935909-3-costa.shul@redhat.com> (raw)
In-Reply-To: <20240211135213.2518068-1-costa.shul@redhat.com>
During CPU-down hotplug, hrtimers may migrate to isolated CPUs,
compromising CPU isolation. This commit addresses this issue by
masking valid CPUs for hrtimers using housekeeping_cpumask(HK_TYPE_TIMER).
Suggested-by: Waiman Long <longman@redhat.com>
Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
Reviewed-by: Waiman Long <longman@redhat.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
---
Changes in v2:
- [v1] https://lore.kernel.org/all/20240211135213.2518068-1-costa.shul@redhat.com/
- reworded and rebased on linux-next
---
kernel/time/hrtimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
index edb0f821dcea..947bd6cf7105 100644
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -2224,7 +2224,7 @@ static void migrate_hrtimer_list(struct hrtimer_clock_base *old_base,
int hrtimers_cpu_dying(unsigned int dying_cpu)
{
struct hrtimer_cpu_base *old_base, *new_base;
- int i, ncpu = cpumask_first(cpu_active_mask);
+ int i, ncpu = cpumask_any_and(cpu_active_mask, housekeeping(HK_TYPE_TIMER));
tick_cancel_sched_timer(dying_cpu);
--
2.43.0
next prev parent reply other threads:[~2024-02-13 16:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 13:52 [PATCH] " Costa Shulyupin
2024-02-11 16:37 ` Waiman Long
2024-02-12 15:23 ` Frederic Weisbecker
2024-02-13 12:36 ` Thomas Gleixner
2024-02-13 16:46 ` Costa Shulyupin [this message]
2024-02-13 19:41 ` [PATCH v2] " Thomas Gleixner
2024-02-13 19:49 ` [tip: timers/core] hrtimer: Select " tip-bot2 for Costa Shulyupin
2024-02-14 9:01 ` [PATCH v2] hrtimer: select " Borislav Petkov
2024-02-14 9:10 ` Thomas Gleixner
2024-02-19 14:33 ` [PATCH v3] " Costa Shulyupin
2024-02-19 16:27 ` Thomas Gleixner
2024-02-22 20:08 ` [PATCH v4] " Costa Shulyupin
2024-02-22 21:24 ` [tip: timers/core] hrtimer: Select " tip-bot2 for Costa Shulyupin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213164650.2935909-3-costa.shul@redhat.com \
--to=costa.shul@redhat.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®