From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Subject: [PATCH 5/9] drm/mediatek: Drop calling cmdq_pkt_finalize()
Date: Thu, 15 Feb 2024 00:49:27 +0000 [thread overview]
Message-ID: <20240215004931.3808-6-chunkuang.hu@kernel.org> (raw)
In-Reply-To: <20240215004931.3808-1-chunkuang.hu@kernel.org>
For some client driver, it want to reduce latency between excuting
previous packet command and next packet command, so append jump
command to the end of previous packet and the jump destination
address is the start address of next packet command buffer. Before
next packet exist, the previous packet has no information of where
to jump to, so append nop command first. When next packet exist,
change nop command to jump command. For mediatek drm driver, it
never has next packet, so appending nop command is redundant.
Because cmdq_pkt_finalize() would append nop command, so change
calling cmdq_pkt_finalize() to cmdq_pkt_eoc() to prevent append
redundant nop command.
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
---
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
index c729af3b9822..df693fa268ce 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
@@ -593,7 +593,7 @@ static void mtk_drm_crtc_update_config(struct mtk_drm_crtc *mtk_crtc,
cmdq_pkt_clear_event(cmdq_handle, mtk_crtc->cmdq_event);
cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event, false);
mtk_crtc_ddp_config(crtc, cmdq_handle);
- cmdq_pkt_finalize(cmdq_handle);
+ cmdq_pkt_eoc(cmdq_handle);
dma_sync_single_for_device(mtk_crtc->cmdq_client.chan->mbox->dev,
cmdq_handle->pa_base,
cmdq_handle->cmd_buf_size,
--
2.34.1
next prev parent reply other threads:[~2024-02-15 0:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 0:49 [PATCH 0/9] Remove cl in struct cmdq_pkt Chun-Kuang Hu
2024-02-15 0:49 ` [PATCH 1/9] soc: mediatek: cmdq: Remove unused helper funciton Chun-Kuang Hu
2024-02-15 10:40 ` AngeloGioacchino Del Regno
2024-02-16 2:11 ` CK Hu (胡俊光)
2024-02-15 0:49 ` [PATCH 2/9] soc: mediatek: cmdq: Add parameter shift_pa to cmdq_pkt_jump() Chun-Kuang Hu
2024-02-15 10:40 ` AngeloGioacchino Del Regno
2024-02-16 1:36 ` CK Hu (胡俊光)
2024-02-15 0:49 ` [PATCH 3/9] soc: mediatek: cmdq: Add cmdq_pkt_eoc() helper function Chun-Kuang Hu
2024-02-15 10:40 ` AngeloGioacchino Del Regno
2024-02-15 0:49 ` [PATCH 4/9] soc: mediatek: cmdq: Add cmdq_pkt_nop() " Chun-Kuang Hu
2024-02-15 10:40 ` AngeloGioacchino Del Regno
2024-02-16 1:39 ` CK Hu (胡俊光)
2024-02-15 0:49 ` Chun-Kuang Hu [this message]
2024-02-15 10:40 ` [PATCH 5/9] drm/mediatek: Drop calling cmdq_pkt_finalize() AngeloGioacchino Del Regno
2024-02-15 0:49 ` [PATCH 6/9] media: platform: mtk-mdp3: drop " Chun-Kuang Hu
2024-02-15 10:29 ` AngeloGioacchino Del Regno
2024-02-16 6:20 ` Moudy Ho (何宗原)
2024-02-16 7:56 ` AngeloGioacchino Del Regno
2024-02-22 3:11 ` CK Hu (胡俊光)
2024-02-15 0:49 ` [PATCH 7/9] soc: mediatek: cmdq: Remove cmdq_pkt_finalize() helper function Chun-Kuang Hu
2024-02-15 0:49 ` [PATCH 8/9] drm/mediatek: Do not store struct cmdq_client in struct cmdq_pkt Chun-Kuang Hu
2024-02-15 10:40 ` AngeloGioacchino Del Regno
2024-02-15 0:49 ` [PATCH 9/9] media: platform: mtk-mdp3: do " Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215004931.3808-6-chunkuang.hu@kernel.org \
--to=chunkuang.hu@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®