From: Arnd Bergmann <arnd@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: [PATCH] irq_work: allow building non-SMP again
Date: Fri, 16 Feb 2024 17:35:07 +0100 [thread overview]
Message-ID: <20240216163535.1997122-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
A lot of important features rely on CONFIG_IRQ_WORK but can be enabled
for non-SMP kernels, which now causes a Kconfig warning:
WARNING: unmet direct dependencies detected for IRQ_WORK
Depends on [n]: SMP [=n]
Selected by [y]:
- PRINTK [=y]
- IRQ_SIM [=y]
- BPF_SYSCALL [=y]
- TASKS_RCU [=y]
- TASKS_RUDE_RCU [=y]
- TASKS_TRACE_RCU [=y]
- PERF_EVENTS [=y] && HAVE_PERF_EVENTS [=y]
- CPU_FREQ_GOV_COMMON [=y] && CPU_FREQ [=y]
- DMA_SHARED_BUFFER [=y]
- ATLAS_PH_SENSOR [=y] && IIO [=y] && I2C [=y]
- GP2AP020A00F [=y] && IIO [=y] && I2C [=y]
- IIO_SYSFS_TRIGGER [=y] && IIO [=y] && IIO_TRIGGER [=y] && SYSFS [=y]
- RING_BUFFER [=y]
Change it so that IRQ_WORK remains default-enabled for SMP kernels
and disabled for UP but can still be selected by other subsystems.
Fixes: 9d6efa8d0dd0 ("workqueue, irq_work: Build fix for !CONFIG_IRQ_WORK")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I assume this has already been reported by others, but I didn't immediately
see another patch for it.
---
init/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index 694891231bd6..68024f5e8f02 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -115,9 +115,7 @@ config CONSTRUCTORS
bool
config IRQ_WORK
- bool
- depends on SMP
- default y
+ def_bool SMP
config BUILDTIME_TABLE_SORT
bool
--
2.39.2
next reply other threads:[~2024-02-16 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 16:35 Arnd Bergmann [this message]
2024-02-16 16:42 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216163535.1997122-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®