From: Andrew Morton <akpm@linux-foundation.org>
To: Donet Tom <donettom@linux.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Aneesh Kumar <aneesh.kumar@kernel.org>,
Huang Ying <ying.huang@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Mel Gorman <mgorman@suse.de>,
Ben Widawsky <ben.widawsky@intel.com>,
Feng Tang <feng.tang@intel.com>, Michal Hocko <mhocko@kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@surriel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Matthew Wilcox <willy@infradead.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Dan Williams <dan.j.williams@intel.com>,
Hugh Dickins <hughd@google.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Suren Baghdasaryan <surenb@google.com>
Subject: Re: [PATCH 1/3] mm/mempolicy: Use the already fetched local variable
Date: Sun, 18 Feb 2024 13:38:51 -0800 [thread overview]
Message-ID: <20240218133851.22c22b55460e866a099be5ce@linux-foundation.org> (raw)
In-Reply-To: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com>
On Sat, 17 Feb 2024 01:31:33 -0600 Donet Tom <donettom@linux.ibm.com> wrote:
> Avoid doing a per cpu read and use the local variable thisnid. IMHO
> this also makes the code more readable.
>
> ...
>
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -2526,7 +2526,7 @@ int mpol_misplaced(struct folio *folio, struct vm_area_struct *vma,
> if (node_isset(curnid, pol->nodes))
> goto out;
> z = first_zones_zonelist(
> - node_zonelist(numa_node_id(), GFP_HIGHUSER),
> + node_zonelist(thisnid, GFP_HIGHUSER),
> gfp_zone(GFP_HIGHUSER),
> &pol->nodes);
> polnid = zone_to_nid(z->zone);
int thisnid = cpu_to_node(thiscpu);
Is there any dofference between numa_node_id() and
cpu_to_node(raw_smp_processor_id())? And it it explicable that we're
using one here and not the other?
next prev parent reply other threads:[~2024-02-18 21:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 7:31 Donet Tom
2024-02-17 7:31 ` [PATCH 2/3] mm/mempolicy: Avoid the fallthrough with MPOLD_BIND in mpol_misplaced Donet Tom
2024-02-19 12:02 ` Michal Hocko
2024-02-19 15:18 ` Donet Tom
2024-02-17 7:31 ` [PATCH 3/3] mm/numa_balancing:Allow migrate on protnone reference with MPOL_PREFERRED_MANY policy Donet Tom
2024-02-19 12:07 ` Michal Hocko
2024-02-19 13:44 ` Donet Tom
2024-02-20 6:36 ` Huang, Ying
2024-02-20 6:44 ` Aneesh Kumar K.V
2024-02-20 7:23 ` Huang, Ying
2024-02-20 7:46 ` Aneesh Kumar K.V
2024-02-20 8:01 ` Huang, Ying
2024-02-19 14:20 ` Michal Hocko
2024-02-19 15:07 ` Donet Tom
2024-02-19 19:12 ` Michal Hocko
2024-02-20 3:57 ` Aneesh Kumar K.V
2024-02-20 8:48 ` Michal Hocko
2024-02-26 13:09 ` Donet Tom
2024-02-20 7:18 ` Huang, Ying
2024-02-20 7:53 ` Aneesh Kumar K.V
2024-02-20 7:58 ` Huang, Ying
2024-03-03 6:16 ` Aneesh Kumar K.V
2024-03-04 1:59 ` Huang, Ying
2024-02-18 21:38 ` Andrew Morton [this message]
2024-02-19 8:34 ` [PATCH 1/3] mm/mempolicy: Use the already fetched local variable Donet Tom
2024-02-20 1:21 ` Andrew Morton
2024-02-20 4:10 ` Aneesh Kumar K.V
2024-02-20 6:25 ` Huang, Ying
2024-02-20 6:32 ` Aneesh Kumar K.V
2024-02-20 7:03 ` Aneesh Kumar K.V
2024-02-20 7:22 ` Huang, Ying
2024-02-20 9:03 ` Michal Hocko
2024-03-03 6:17 ` Aneesh Kumar K.V
2024-03-04 1:49 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240218133851.22c22b55460e866a099be5ce@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=aneesh.kumar@kernel.org \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=donettom@linux.ibm.com \
--cc=feng.tang@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®