From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD4FA535C6 for ; Tue, 20 Feb 2024 03:30:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708399849; cv=none; b=ckY18HKVYSQVIoV95RVKxCFPwwug/WQ2VBbMIswWLJxRXXKnPbGa3y7fEbLTYB4Y3u3PkkqGtkuF2U0fB70eVA6jUWSxf36OCsEZPyXnYLzqn6Dr3tnJ2RDiVMgLRzO6rP9p7LRqhgW5iq0cc3SZ6LzNKfm569tQQuYOw9953V4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708399849; c=relaxed/simple; bh=OWejHLNepLGujaSbGpbMAP1AbglW7ePwckLXsnJRIRA=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=gP/vyiHz8ucl01YjhSGjcPHeYzJOf7EQ/4U80+yiWFi7P4esQdQQlLWUEP7hMS9sIRo+aRGiTLWxY1pIJvSYkbXJyfv78lTvvcbci4i/qAqoWZpL+cg5vFIevWf1+qfmJjvl3Ovx7CtvQ1yNY67F16IvwiAUJsx5Tp1KOPCyczE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=kmNL7KnP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="kmNL7KnP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE2CAC433F1; Tue, 20 Feb 2024 03:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1708399849; bh=OWejHLNepLGujaSbGpbMAP1AbglW7ePwckLXsnJRIRA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kmNL7KnPWDgYtHVRH+k7+MYZngA/necwn0aQF/wGHYh/HzRTyQIpXcuc0lbVdJ2gB xvZHH912ChleVwhFE00ZEmE2MhsjkL5hrC6ZcN0oJFClARNqs6B0cWKjww25WNmLJa IwsNbkuXKvtgNbGvObptBrwtFvcQ9PWxKF0TtZ6Q= Date: Mon, 19 Feb 2024 19:30:48 -0800 From: Andrew Morton To: Baolin Wang Cc: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Huang, Ying" , Ryan Roberts , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: Re: [PATCH v6 0/4] Enable >0 order folio memory compaction Message-Id: <20240219193048.cbd010579aa3d2c790f6e2b9@linux-foundation.org> In-Reply-To: <4f0b3586-25e2-4d21-bbb6-41f644d3d77f@linux.alibaba.com> References: <20240216170432.1268753-1-zi.yan@sent.com> <20240219180617.89a0daaba45ce124ef01be50@linux-foundation.org> <9E3E6CD6-45DD-4E7F-B6DC-0897F38D5E81@nvidia.com> <4f0b3586-25e2-4d21-bbb6-41f644d3d77f@linux.alibaba.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 20 Feb 2024 11:00:39 +0800 Baolin Wang wrote: > > The patch was based on top of my early version of this patchset, thus > > uses "cc->nr_migratepages -= 1 << order;" and > > "cc->nr_migratepages += 1 << order;", but now it is applied before > > mine. The change should be "cc->nr_migratepages--;" and > > "cc->nr_migratepages++;", respectively. > > > >> > >>> on nr_migratepages was based on this one, a better fixup > >>> for it might be below. Since before my patchset, compaction only deals with > >>> order-0 pages. > >> > >> I don't understand what this means. The patchset you sent applies OK > >> to mm-unstable so what else is there to do? > > > > Your above fixup to Baolin's patch needs to be changed to the patch below > > and my "mm/compaction: add support for >0 order folio memory compaction" will > > need to be adjusted accordingly to be applied on top. > > > > Let me know if anything is unclear. > > Hi Andrew, > > To avoid conflicts, you can drop these two patches, and I will send a > new version with fixing the issue pointed by Vlastimilb on top of > "mm/compaction: add support for >0 order folio memory compaction". > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-everything-2024-02-16-01-35&id=97f749c7c82f677f89bbf4f10de7816ce9b071fe > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-everything-2024-02-16-01-35&id=ea87b0558293a5ad597bea606fe261f7b2650cda Well I thought I'd fixed everything up 10 minutes ago. Please take a look at next mm-unstable.