From: Oded Gabbay <ogabbay@kernel.org>
To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Tomer Tayar <ttayar@habana.ai>
Subject: [PATCH 03/13] accel/habanalabs: modify print for skip loading linux FW to debug log
Date: Tue, 20 Feb 2024 18:01:19 +0200 [thread overview]
Message-ID: <20240220160129.909714-3-ogabbay@kernel.org> (raw)
In-Reply-To: <20240220160129.909714-1-ogabbay@kernel.org>
From: Tomer Tayar <ttayar@habana.ai>
Skip loading a linux FW image into the device with the current supported
ASICs is done for test purposes only.
Moreover, for future supported ASICs it is possible that there won't be
a need to load such an image.
The print in such a case is therefore not needed in most cases, so
replace the used dev_info() with dev_dbg().
Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
---
drivers/accel/habanalabs/common/firmware_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/habanalabs/common/firmware_if.c b/drivers/accel/habanalabs/common/firmware_if.c
index e7dcf2fe6552..364d292c76fa 100644
--- a/drivers/accel/habanalabs/common/firmware_if.c
+++ b/drivers/accel/habanalabs/common/firmware_if.c
@@ -2820,7 +2820,7 @@ static int hl_fw_dynamic_init_cpu(struct hl_device *hdev,
hdev->asic_funcs->init_cpu_scrambler_dram(hdev);
if (!(hdev->fw_components & FW_TYPE_LINUX)) {
- dev_info(hdev->dev, "Skip loading Linux F/W\n");
+ dev_dbg(hdev->dev, "Skip loading Linux F/W\n");
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2024-02-20 16:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 16:01 [PATCH 01/13] accel/habanalabs/gaudi2: use single function to compare FW versions Oded Gabbay
2024-02-20 16:01 ` [PATCH 02/13] accel/habanalabs: remove hop size from asic properties Oded Gabbay
2024-02-23 22:42 ` Carl Vanderlip
2024-02-20 16:01 ` Oded Gabbay [this message]
2024-02-23 22:45 ` [PATCH 03/13] accel/habanalabs: modify print for skip loading linux FW to debug log Carl Vanderlip
2024-02-20 16:01 ` [PATCH 04/13] accel/habanalabs/gaudi2: check extended errors according to PCIe addr_dec interrupt info Oded Gabbay
2024-02-23 22:49 ` Carl Vanderlip
2024-02-20 16:01 ` [PATCH 05/13] accel/habanalabs: fix glbl error cause handling Oded Gabbay
2024-02-23 23:01 ` Carl Vanderlip
2024-02-20 16:01 ` [PATCH 06/13] accel/habanalabs: fix debugfs files permissions Oded Gabbay
2024-02-23 23:10 ` Carl Vanderlip
2024-02-20 16:01 ` [PATCH 07/13] accel/habanalabs: initialize maybe-uninitialized variables Oded Gabbay
2024-02-23 23:12 ` Carl Vanderlip
2024-02-20 16:01 ` [PATCH 08/13] accel/habanalabs: fix error print Oded Gabbay
2024-02-23 23:15 ` Carl Vanderlip
2024-02-20 16:01 ` [PATCH 09/13] accel/habanalabs/gaudi2: drain event lacks rd/wr indication Oded Gabbay
2024-02-23 23:17 ` Carl Vanderlip
2024-02-20 16:01 ` [PATCH 10/13] accel/habanalabs/hwmon: rate limit errors user can generate Oded Gabbay
2024-02-23 23:21 ` Carl Vanderlip
2024-02-20 16:01 ` [PATCH 11/13] accel/habanalabs: handle reserved memory request when working with full FW Oded Gabbay
2024-02-23 23:24 ` Carl Vanderlip
2024-02-20 16:01 ` [PATCH 12/13] accel/habanalabs: keep explicit size of reserved memory for FW Oded Gabbay
2024-02-23 23:26 ` Carl Vanderlip
2024-02-20 16:01 ` [PATCH 13/13] accel/habanalabs: modify pci health check Oded Gabbay
2024-02-23 23:32 ` Carl Vanderlip
2024-02-24 19:20 ` Ofir Bitton
2024-02-23 22:38 ` [PATCH 01/13] accel/habanalabs/gaudi2: use single function to compare FW versions Carl Vanderlip
2024-02-25 10:36 ` Ohad Sharabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220160129.909714-3-ogabbay@kernel.org \
--to=ogabbay@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ttayar@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®