From: "Mickaël Salaün" <mic@digikod.net>
To: Casey Schaufler <casey@schaufler-ca.com>,
John Johansen <john.johansen@canonical.com>,
Paul Moore <paul@paul-moore.com>
Cc: James Morris <jmorris@namei.org>,
"Serge E . Hallyn" <serge@hallyn.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] SELinux: Fix lsm_get_self_attr()
Date: Fri, 23 Feb 2024 21:03:52 +0100 [thread overview]
Message-ID: <20240223.eij0Oudai0Ia@digikod.net> (raw)
In-Reply-To: <20240223.ieSh2aegurig@digikod.net>
On Fri, Feb 23, 2024 at 08:59:34PM +0100, Mickaël Salaün wrote:
> On Fri, Feb 23, 2024 at 08:05:45PM +0100, Mickaël Salaün wrote:
> > selinux_lsm_getattr() may not initialize the value's pointer in some
> > case. As for proc_pid_attr_read(), initialize this pointer to NULL in
> > selinux_getselfattr() to avoid an UAF in the kfree() call.
>
> Not UAF but NULL pointer dereference (both patches)...
Well, that may be the result (as observed with the kfree() call), but
the cause is obviously an uninitialized pointer.
next prev parent reply other threads:[~2024-02-23 20:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 19:05 Mickaël Salaün
2024-02-23 19:05 ` [PATCH 2/2] AppArmor: " Mickaël Salaün
2024-02-23 21:07 ` Paul Moore
2024-02-26 19:59 ` Paul Moore
2024-02-27 16:01 ` Paul Moore
2024-02-27 22:09 ` Paul Moore
2024-02-27 22:13 ` Paul Moore
2024-02-28 12:53 ` Mickaël Salaün
2024-05-10 16:10 ` John Johansen
2024-05-13 14:57 ` Paul Moore
2024-02-23 19:16 ` [PATCH 1/2] SELinux: " Mickaël Salaün
2024-02-23 20:47 ` Paul Moore
2024-02-23 19:59 ` Mickaël Salaün
2024-02-23 20:03 ` Mickaël Salaün [this message]
2024-02-23 21:05 ` Paul Moore
2024-02-23 22:03 ` Mickaël Salaün
2024-02-23 22:21 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223.eij0Oudai0Ia@digikod.net \
--to=mic@digikod.net \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®