From: Dongli Zhang <dongli.zhang@oracle.com>
To: x86@kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, joe.jin@oracle.com
Subject: [PATCH 1/1] x86/split_lock: add the source of exception to warning logs
Date: Fri, 23 Feb 2024 01:47:46 -0800 [thread overview]
Message-ID: <20240223094746.11305-1-dongli.zhang@oracle.com> (raw)
Currently to trigger split lock exception at the guest side will print the
below to host logs.
"x86/split lock detection: #AC: CPU 1/KVM/65886 took a split_lock trap at
address: 0x401173"
Although it is more likely the split lock exception is from the guest side,
differentiate if it is from the guest side, or the host userspace
VMM (e.g., QEMU).
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
arch/x86/kernel/cpu/intel.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index a927a8fc9624..22285e7cc138 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -1155,14 +1155,15 @@ static int splitlock_cpu_offline(unsigned int cpu)
return 0;
}
-static void split_lock_warn(unsigned long ip)
+static void split_lock_warn(unsigned long ip, bool is_guest)
{
struct delayed_work *work;
int cpu;
if (!current->reported_split_lock)
- pr_warn_ratelimited("#AC: %s/%d took a split_lock trap at address: 0x%lx\n",
- current->comm, current->pid, ip);
+ pr_warn_ratelimited("#AC: %s/%d (%s) took a split_lock trap at address: 0x%lx\n",
+ current->comm, current->pid,
+ is_guest ? "guest" : "user", ip);
current->reported_split_lock = 1;
if (sysctl_sld_mitigate) {
@@ -1194,11 +1195,11 @@ static void split_lock_warn(unsigned long ip)
bool handle_guest_split_lock(unsigned long ip)
{
if (sld_state == sld_warn) {
- split_lock_warn(ip);
+ split_lock_warn(ip, true);
return true;
}
- pr_warn_once("#AC: %s/%d %s split_lock trap at address: 0x%lx\n",
+ pr_warn_once("#AC: %s/%d %s (guest) split_lock trap at address: 0x%lx\n",
current->comm, current->pid,
sld_state == sld_fatal ? "fatal" : "bogus", ip);
@@ -1237,7 +1238,7 @@ bool handle_user_split_lock(struct pt_regs *regs, long error_code)
{
if ((regs->flags & X86_EFLAGS_AC) || sld_state == sld_fatal)
return false;
- split_lock_warn(regs->ip);
+ split_lock_warn(regs->ip, false);
return true;
}
--
2.34.1
next reply other threads:[~2024-02-23 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 9:47 Dongli Zhang [this message]
2024-02-23 16:27 ` Dave Hansen
2024-02-24 3:19 ` Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223094746.11305-1-dongli.zhang@oracle.com \
--to=dongli.zhang@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®