From: Armin Wolf <W_Armin@gmx.de>
To: Shyam-sundar.S-k@amd.com, mika.westerberg@linux.intel.com
Cc: sathyanarayanan.kuppuswamy@linux.intel.com, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] platform/x86: intel_scu_ipcutil: Make scu static
Date: Fri, 23 Feb 2024 17:39:01 +0100 [thread overview]
Message-ID: <20240223163901.13504-3-W_Armin@gmx.de> (raw)
In-Reply-To: <20240223163901.13504-1-W_Armin@gmx.de>
The variable is only used internally and has no external users,
so it should me made static.
Compile-tested only.
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
Changes since v1:
- remove Fixes tag
- add Reviewed-by tag
---
drivers/platform/x86/intel_scu_ipcutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c
index b7c10c15a3d6..7d87cbd4b9c6 100644
--- a/drivers/platform/x86/intel_scu_ipcutil.c
+++ b/drivers/platform/x86/intel_scu_ipcutil.c
@@ -22,7 +22,7 @@
static int major;
-struct intel_scu_ipc_dev *scu;
+static struct intel_scu_ipc_dev *scu;
static DEFINE_MUTEX(scu_lock);
/* IOCTL commands */
--
2.39.2
next prev parent reply other threads:[~2024-02-23 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 16:38 [PATCH v2 1/3] platform/x86/amd/pmf: Add missing __iomem attribute to policy_base Armin Wolf
2024-02-23 16:39 ` [PATCH v2 2/3] platform/x86/amd/pmf: Do not use readl() for policy buffer access Armin Wolf
2024-02-27 12:59 ` Ilpo Järvinen
2024-02-27 13:41 ` Armin Wolf
2024-02-23 16:39 ` Armin Wolf [this message]
2024-02-26 6:39 ` [PATCH v2 3/3] platform/x86: intel_scu_ipcutil: Make scu static Mika Westerberg
2024-02-27 13:06 ` Ilpo Järvinen
2024-02-26 6:41 ` [PATCH v2 1/3] platform/x86/amd/pmf: Add missing __iomem attribute to policy_base Kuppuswamy Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223163901.13504-3-W_Armin@gmx.de \
--to=w_armin@gmx.de \
--cc=Shyam-sundar.S-k@amd.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®