From: Qais Yousef <qyousef@layalina.io>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>, Wei Wang <wvw@google.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2 2/2] block/blk-mq: Don't complete locally if capacities are different
Date: Sat, 24 Feb 2024 23:06:24 +0000 [thread overview]
Message-ID: <20240224230624.3sk3b5pmhoi67c3r@airbuntu> (raw)
In-Reply-To: <8fc70827-9785-48d0-9a43-e1e3674317e9@acm.org>
On 02/23/24 08:09, Bart Van Assche wrote:
> On 2/23/24 07:57, Qais Yousef wrote:
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 2dc01551e27c..ea69047e12f7 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -1167,10 +1167,11 @@ static inline bool blk_mq_complete_need_ipi(struct request *rq)
> > if (force_irqthreads())
> > return false;
> > - /* same CPU or cache domain? Complete locally */
> > + /* same CPU or cache domain and capacity? Complete locally */
> > if (cpu == rq->mq_ctx->cpu ||
> > (!test_bit(QUEUE_FLAG_SAME_FORCE, &rq->q->queue_flags) &&
> > - cpus_share_cache(cpu, rq->mq_ctx->cpu)))
> > + cpus_share_cache(cpu, rq->mq_ctx->cpu) &&
> > + cpus_equal_capacity(cpu, rq->mq_ctx->cpu)))
> > return false;
> > /* don't try to IPI to an offline CPU */
>
> I think it's worth mentioning that this change is intended for storage
> controllers that only support a single completion interrupt. Anyway:
Sorry I didn't realize it is only applied for this scenario.
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Thanks for the reviews!
next prev parent reply other threads:[~2024-02-24 23:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 15:57 [PATCH v2 0/2] sched: blk: Handle HMP systems when completing IO Qais Yousef
2024-02-23 15:57 ` [PATCH v2 1/2] sched: Add a new function to compare if two cpus have the same capacity Qais Yousef
2024-02-23 16:12 ` Bart Van Assche
2024-02-23 15:57 ` [PATCH v2 2/2] block/blk-mq: Don't complete locally if capacities are different Qais Yousef
2024-02-23 16:09 ` Bart Van Assche
2024-02-24 23:06 ` Qais Yousef [this message]
2024-02-24 13:43 ` [PATCH v2 0/2] sched: blk: Handle HMP systems when completing IO Shrikanth Hegde
2024-02-24 23:12 ` Qais Yousef
2024-02-24 19:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240224230624.3sk3b5pmhoi67c3r@airbuntu \
--to=qyousef@layalina.io \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dietmar.eggemann@arm.com \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®