From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/3] drm_edid: Support getting EDID through ddc without connector
Date: Tue, 27 Feb 2024 17:05:58 -0800 [thread overview]
Message-ID: <20240228011133.1238439-2-hsinyi@chromium.org> (raw)
In-Reply-To: <20240228011133.1238439-1-hsinyi@chromium.org>
Some panels are interested in the EDID during early probe when connector
is still unknown.
Add a function drm_get_edid_no_connector() to get edid without connector.
No functional change for existing usage.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
v1->v2:
add a function to return the entire edid without updating connector.
---
drivers/gpu/drm/drm_edid.c | 45 ++++++++++++++++++++++++++++----------
include/drm/drm_edid.h | 1 +
2 files changed, 34 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 1ad94473e400..15b97c8ed993 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -2364,7 +2364,7 @@ static struct edid *_drm_do_get_edid(struct drm_connector *connector,
struct edid *edid, *new;
size_t alloc_size = EDID_LENGTH;
- override = drm_edid_override_get(connector);
+ override = connector ? drm_edid_override_get(connector) : false;
if (override) {
alloc_size = override->size;
edid = kmemdup(override->edid, alloc_size, GFP_KERNEL);
@@ -2385,18 +2385,20 @@ static struct edid *_drm_do_get_edid(struct drm_connector *connector,
if (status == EDID_BLOCK_READ_FAIL)
goto fail;
- /* FIXME: Clarify what a corrupt EDID actually means. */
- if (status == EDID_BLOCK_OK || status == EDID_BLOCK_VERSION)
- connector->edid_corrupt = false;
- else
- connector->edid_corrupt = true;
+ if (connector) {
+ /* FIXME: Clarify what a corrupt EDID actually means. */
+ if (status == EDID_BLOCK_OK || status == EDID_BLOCK_VERSION)
+ connector->edid_corrupt = false;
+ else
+ connector->edid_corrupt = true;
- if (!edid_block_status_valid(status, edid_block_tag(edid))) {
- if (status == EDID_BLOCK_ZERO)
- connector->null_edid_counter++;
+ if (!edid_block_status_valid(status, edid_block_tag(edid))) {
+ if (status == EDID_BLOCK_ZERO)
+ connector->null_edid_counter++;
- connector_bad_edid(connector, edid, 1);
- goto fail;
+ connector_bad_edid(connector, edid, 1);
+ goto fail;
+ }
}
if (!edid_extension_block_count(edid))
@@ -2444,7 +2446,8 @@ static struct edid *_drm_do_get_edid(struct drm_connector *connector,
}
if (invalid_blocks) {
- connector_bad_edid(connector, edid, num_blocks);
+ if (connector)
+ connector_bad_edid(connector, edid, num_blocks);
edid = edid_filter_invalid_blocks(edid, &alloc_size);
}
@@ -2637,6 +2640,24 @@ struct edid *drm_get_edid(struct drm_connector *connector,
}
EXPORT_SYMBOL(drm_get_edid);
+/**
+ * drm_get_edid_no_connector - get EDID data without updating connector status
+ * @adapter: I2C adapter to use for DDC
+ *
+ * Similar to drm_edid_read_ddc(), but not checking any connector status. Use
+ * this function to get EDID when connector is still unknown.
+ *
+ * Return: Pointer to valid EDID or NULL if we couldn't find any.
+ */
+struct edid *drm_get_edid_no_connector(struct i2c_adapter *adapter)
+{
+ if (!drm_probe_ddc(adapter))
+ return NULL;
+
+ return _drm_do_get_edid(NULL, drm_do_probe_ddc_edid, adapter, NULL);
+}
+EXPORT_SYMBOL(drm_get_edid_no_connector);
+
/**
* drm_edid_read_custom - Read EDID data using given EDID block read function
* @connector: Connector to use
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
index 70ae6c290bdc..80c9e32ff80e 100644
--- a/include/drm/drm_edid.h
+++ b/include/drm/drm_edid.h
@@ -565,6 +565,7 @@ struct edid *drm_do_get_edid(struct drm_connector *connector,
void *data);
struct edid *drm_get_edid(struct drm_connector *connector,
struct i2c_adapter *adapter);
+struct edid *drm_get_edid_no_connector(struct i2c_adapter *adapter);
u32 drm_edid_get_panel_id(struct i2c_adapter *adapter);
struct edid *drm_get_edid_switcheroo(struct drm_connector *connector,
struct i2c_adapter *adapter);
--
2.44.0.rc1.240.g4c46232300-goog
next prev parent reply other threads:[~2024-02-28 1:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 1:05 [PATCH v2 0/3] Match panel with id and name Hsin-Yi Wang
2024-02-28 1:05 ` Hsin-Yi Wang [this message]
2024-02-28 1:28 ` [PATCH v2 1/3] drm_edid: Support getting EDID through ddc without connector Hsin-Yi Wang
2024-02-29 0:21 ` Doug Anderson
2024-02-29 0:54 ` Hsin-Yi Wang
2024-02-28 1:05 ` [PATCH v2 2/3] drm/panel: panel-edp: Match edp_panels with panel name Hsin-Yi Wang
2024-02-28 3:59 ` Dmitry Baryshkov
2024-02-29 0:21 ` Doug Anderson
2024-02-28 1:06 ` [PATCH v2 3/3] drm/panel: panel-edp: Fix AUO 0x405c panel naming and add a variant Hsin-Yi Wang
2024-02-29 0:22 ` Doug Anderson
2024-02-29 1:04 ` Hsin-Yi Wang
2024-02-29 1:12 ` Dmitry Baryshkov
2024-02-29 1:17 ` Hsin-Yi Wang
2024-03-04 20:05 ` Hsin-Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228011133.1238439-2-hsinyi@chromium.org \
--to=hsinyi@chromium.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®