mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Shuah Khan <skhan@linuxfoundation.org>,
	Brendan Higgins <brendanhiggins@google.com>
Cc: David Gow <davidgow@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the kunit-next tree
Date: Wed, 28 Feb 2024 13:48:18 +1100	[thread overview]
Message-ID: <20240228134818.7b6134dc@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 16189 bytes --]

Hi all,

After merging the kunit-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/gpu/drm/tests/drm_buddy_test.c:7:
drivers/gpu/drm/tests/drm_buddy_test.c: In function 'drm_test_buddy_alloc_contiguous':
drivers/gpu/drm/tests/drm_buddy_test.c:58:40: error: format '%u' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
   58 |                                        "buddy_alloc hit an error size=%u\n",
      |                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   59 |                                        ps);
      |                                        ~~
      |                                        |
      |                                        long unsigned int
include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
  597 |                                     fmt,                                       \
      |                                     ^~~
include/kunit/test.h:662:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION'
  662 |         KUNIT_UNARY_ASSERTION(test,                                            \
      |         ^~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:1233:9: note: in expansion of macro 'KUNIT_FALSE_MSG_ASSERTION'
 1233 |         KUNIT_FALSE_MSG_ASSERTION(test,                                        \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:55:17: note: in expansion of macro 'KUNIT_ASSERT_FALSE_MSG'
   55 |                 KUNIT_ASSERT_FALSE_MSG(test,
      |                 ^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:58:72: note: format string is defined here
   58 |                                        "buddy_alloc hit an error size=%u\n",
      |                                                                       ~^
      |                                                                        |
      |                                                                        unsigned int
      |                                                                       %lu
drivers/gpu/drm/tests/drm_buddy_test.c:65:32: error: format '%u' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
   65 |                                "buddy_alloc didn't error size=%u\n", 3 * ps);
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~
      |                                                                        |
      |                                                                        long unsigned int
include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
  597 |                                     fmt,                                       \
      |                                     ^~~
include/kunit/test.h:654:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION'
  654 |         KUNIT_UNARY_ASSERTION(test,                                            \
      |         ^~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:1214:9: note: in expansion of macro 'KUNIT_TRUE_MSG_ASSERTION'
 1214 |         KUNIT_TRUE_MSG_ASSERTION(test,                                         \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:62:9: note: in expansion of macro 'KUNIT_ASSERT_TRUE_MSG'
   62 |         KUNIT_ASSERT_TRUE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size,
      |         ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:65:64: note: format string is defined here
   65 |                                "buddy_alloc didn't error size=%u\n", 3 * ps);
      |                                                               ~^
      |                                                                |
      |                                                                unsigned int
      |                                                               %lu
drivers/gpu/drm/tests/drm_buddy_test.c:71:32: error: format '%u' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
   71 |                                "buddy_alloc didn't error size=%u\n", 3 * ps);
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~
      |                                                                        |
      |                                                                        long unsigned int
include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
  597 |                                     fmt,                                       \
      |                                     ^~~
include/kunit/test.h:654:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION'
  654 |         KUNIT_UNARY_ASSERTION(test,                                            \
      |         ^~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:1214:9: note: in expansion of macro 'KUNIT_TRUE_MSG_ASSERTION'
 1214 |         KUNIT_TRUE_MSG_ASSERTION(test,                                         \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:68:9: note: in expansion of macro 'KUNIT_ASSERT_TRUE_MSG'
   68 |         KUNIT_ASSERT_TRUE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size,
      |         ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:71:64: note: format string is defined here
   71 |                                "buddy_alloc didn't error size=%u\n", 3 * ps);
      |                                                               ~^
      |                                                                |
      |                                                                unsigned int
      |                                                               %lu
drivers/gpu/drm/tests/drm_buddy_test.c:75:32: error: format '%u' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
   75 |                                "buddy_alloc didn't error size=%u\n", 2 * ps);
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~
      |                                                                        |
      |                                                                        long unsigned int
include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
  597 |                                     fmt,                                       \
      |                                     ^~~
include/kunit/test.h:654:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION'
  654 |         KUNIT_UNARY_ASSERTION(test,                                            \
      |         ^~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:1214:9: note: in expansion of macro 'KUNIT_TRUE_MSG_ASSERTION'
 1214 |         KUNIT_TRUE_MSG_ASSERTION(test,                                         \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:72:9: note: in expansion of macro 'KUNIT_ASSERT_TRUE_MSG'
   72 |         KUNIT_ASSERT_TRUE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size,
      |         ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:75:64: note: format string is defined here
   75 |                                "buddy_alloc didn't error size=%u\n", 2 * ps);
      |                                                               ~^
      |                                                                |
      |                                                                unsigned int
      |                                                               %lu
drivers/gpu/drm/tests/drm_buddy_test.c:81:32: error: format '%u' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
   81 |                                "buddy_alloc didn't error size=%u\n", 3 * ps);
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~
      |                                                                        |
      |                                                                        long unsigned int
include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
  597 |                                     fmt,                                       \
      |                                     ^~~
include/kunit/test.h:654:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION'
  654 |         KUNIT_UNARY_ASSERTION(test,                                            \
      |         ^~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:1214:9: note: in expansion of macro 'KUNIT_TRUE_MSG_ASSERTION'
 1214 |         KUNIT_TRUE_MSG_ASSERTION(test,                                         \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:78:9: note: in expansion of macro 'KUNIT_ASSERT_TRUE_MSG'
   78 |         KUNIT_ASSERT_TRUE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size,
      |         ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:81:64: note: format string is defined here
   81 |                                "buddy_alloc didn't error size=%u\n", 3 * ps);
      |                                                               ~^
      |                                                                |
      |                                                                unsigned int
      |                                                               %lu
drivers/gpu/drm/tests/drm_buddy_test.c:90:32: error: format '%u' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
   90 |                                "buddy_alloc hit an error size=%u\n", 2 * ps);
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~
      |                                                                        |
      |                                                                        long unsigned int
include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
  597 |                                     fmt,                                       \
      |                                     ^~~
include/kunit/test.h:662:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION'
  662 |         KUNIT_UNARY_ASSERTION(test,                                            \
      |         ^~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:1233:9: note: in expansion of macro 'KUNIT_FALSE_MSG_ASSERTION'
 1233 |         KUNIT_FALSE_MSG_ASSERTION(test,                                        \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:87:9: note: in expansion of macro 'KUNIT_ASSERT_FALSE_MSG'
   87 |         KUNIT_ASSERT_FALSE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size,
      |         ^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:90:64: note: format string is defined here
   90 |                                "buddy_alloc hit an error size=%u\n", 2 * ps);
      |                                                               ~^
      |                                                                |
      |                                                                unsigned int
      |                                                               %lu
drivers/gpu/drm/tests/drm_buddy_test.c:96:32: error: format '%u' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
   96 |                                "buddy_alloc hit an error size=%u\n", 3 * ps);
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~
      |                                                                        |
      |                                                                        long unsigned int
include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
  597 |                                     fmt,                                       \
      |                                     ^~~
include/kunit/test.h:662:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION'
  662 |         KUNIT_UNARY_ASSERTION(test,                                            \
      |         ^~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:1233:9: note: in expansion of macro 'KUNIT_FALSE_MSG_ASSERTION'
 1233 |         KUNIT_FALSE_MSG_ASSERTION(test,                                        \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:93:9: note: in expansion of macro 'KUNIT_ASSERT_FALSE_MSG'
   93 |         KUNIT_ASSERT_FALSE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size,
      |         ^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:96:64: note: format string is defined here
   96 |                                "buddy_alloc hit an error size=%u\n", 3 * ps);
      |                                                               ~^
      |                                                                |
      |                                                                unsigned int
      |                                                               %lu
In file included from drivers/gpu/drm/tests/drm_mm_test.c:8:
drivers/gpu/drm/tests/drm_mm_test.c: In function 'drm_test_mm_init':
drivers/gpu/drm/tests/drm_mm_test.c:160:34: error: zero-length gnu_printf format string [-Werror=format-zero-length]
  160 |                 KUNIT_FAIL(test, "");
      |                                  ^~
include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
  597 |                                     fmt,                                       \
      |                                     ^~~
include/kunit/test.h:625:9: note: in expansion of macro 'KUNIT_FAIL_ASSERTION'
  625 |         KUNIT_FAIL_ASSERTION(test,                                             \
      |         ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:160:17: note: in expansion of macro 'KUNIT_FAIL'
  160 |                 KUNIT_FAIL(test, "");
      |                 ^~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:174:34: error: zero-length gnu_printf format string [-Werror=format-zero-length]
  174 |                 KUNIT_FAIL(test, "");
      |                                  ^~
include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
  597 |                                     fmt,                                       \
      |                                     ^~~
include/kunit/test.h:625:9: note: in expansion of macro 'KUNIT_FAIL_ASSERTION'
  625 |         KUNIT_FAIL_ASSERTION(test,                                             \
      |         ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:174:17: note: in expansion of macro 'KUNIT_FAIL'
  174 |                 KUNIT_FAIL(test, "");
      |                 ^~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:181:34: error: zero-length gnu_printf format string [-Werror=format-zero-length]
  181 |                 KUNIT_FAIL(test, "");
      |                                  ^~
include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
  597 |                                     fmt,                                       \
      |                                     ^~~
include/kunit/test.h:625:9: note: in expansion of macro 'KUNIT_FAIL_ASSERTION'
  625 |         KUNIT_FAIL_ASSERTION(test,                                             \
      |         ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:181:17: note: in expansion of macro 'KUNIT_FAIL'
  181 |                 KUNIT_FAIL(test, "");
      |                 ^~~~~~~~~~

Caused by commit

  e00c5a9fa617 ("kunit: Annotate _MSG assertion variants with gnu printf specifiers")

Please fix all the current problems before applying a patch to warn
about them.

I have used the kunit-next tree from next-20240227 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2024-02-28  2:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  2:48 Stephen Rothwell [this message]
2024-02-28  3:26 ` Shuah Khan
  -- strict thread matches above, loose matches on Subject: below --
2025-08-18  2:08 Stephen Rothwell
2025-08-18 16:32 ` Shuah Khan
2025-08-19  7:44   ` David Gow
2025-08-25  6:05     ` Stephen Rothwell
2025-08-26  2:15     ` Shuah Khan
2025-08-26  9:24       ` David Gow
2025-08-27  5:49         ` Shuah Khan
2025-08-27  6:37           ` David Gow
2024-10-04  4:11 Stephen Rothwell
2024-10-04 13:26 ` Gabriela Bittencourt
2024-10-04 18:36 ` Shuah Khan
2024-02-29  4:26 Stephen Rothwell
2024-02-29 15:07 ` Shuah Khan
2024-03-01  7:15   ` David Gow
2024-03-01 10:43     ` Stephen Rothwell
2024-03-01 16:05       ` Shuah Khan
2024-03-01 20:46         ` Stephen Rothwell
2024-03-01 22:30           ` Shuah Khan
2024-03-06 15:25             ` Shuah Khan
2020-01-16  5:57 Stephen Rothwell
2020-01-16 11:23 ` Alan Maguire
2020-01-16 23:27   ` Rafael J. Wysocki
2020-01-10  6:43 Stephen Rothwell
2020-01-10 11:56 ` Alan Maguire
2020-01-13 21:11   ` Brendan Higgins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240228134818.7b6134dc@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®