From: Florian Fainelli <florian.fainelli@broadcom.com>
To: bcm-kernel-feedback-list@broadcom.com,
Arnd Bergmann <arnd@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: bcm: stop selecing CONFIG_TICK_ONESHOT
Date: Wed, 28 Feb 2024 10:32:27 -0800 [thread overview]
Message-ID: <20240228183227.1822982-1-florian.fainelli@broadcom.com> (raw)
In-Reply-To: <20240228123850.3499024-2-arnd@kernel.org>
From: Florian Fainelli <f.fainelli@gmail.com>
On Wed, 28 Feb 2024 13:38:42 +0100, Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> ARCH_BCM_MOBILE is the only platform that selects CONFIG_TICK_ONESHOT,
> the others stopped 12 years ago in commit 98fab064d321 ("ARM: Remove
> unnecessary selection of TICK_ONESHOT").
>
> This inconsistency caused a build regression after an otherwise
> correct change to the timers subsystem:
>
> kernel/time/tick-sched.c:1599:6: error: redefinition of 'tick_sched_timer_dying'
> 1599 | void tick_sched_timer_dying(int cpu)
> | ^
> kernel/time/tick-sched.h:111:20: note: previous definition is here
> 111 | static inline void tick_sched_timer_dying(int cpu) { }
>
> Drop this dead select.
>
> Fixes: 3aedb7fcd88a ("tick/sched: Remove useless oneshot ifdeffery")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/soc/next, thanks!
--
Florian
next prev parent reply other threads:[~2024-02-28 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 12:38 [PATCH 1/2] tick/sched: fix build failure for CONFIG_NO_HZ_COMMON=n Arnd Bergmann
2024-02-28 12:38 ` [PATCH 2/2] ARM: bcm: stop selecing CONFIG_TICK_ONESHOT Arnd Bergmann
2024-02-28 18:32 ` Florian Fainelli [this message]
2024-02-29 16:50 ` [tip: timers/core] tick/sched: Fix build failure for CONFIG_NO_HZ_COMMON=n tip-bot2 for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228183227.1822982-1-florian.fainelli@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=frederic@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®