mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lizhi Xu <lizhi.xu@windriver.com>
To: <syzbot+2622b51b35f91a00ea18@syzkaller.appspotmail.com>
Cc: <syzkaller-bugs@googlegroups.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [syzbot] [media?] [usb?] INFO: task hung in vb2_video_unregister_device
Date: Thu, 29 Feb 2024 15:20:16 +0800	[thread overview]
Message-ID: <20240229072016.186240-1-lizhi.xu@windriver.com> (raw)
In-Reply-To: <0000000000008faf0a06126a0ffb@google.com>

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
index c575198e8354..437f80551a2d 100644
--- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
+++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
@@ -1262,8 +1262,7 @@ void vb2_video_unregister_device(struct video_device *vdev)
 	get_device(&vdev->dev);
 	video_unregister_device(vdev);
 	if (vdev->queue) {
-		struct mutex *lock = vdev->queue->lock ?
-			vdev->queue->lock : vdev->lock;
+		struct mutex *lock = vdev->queue->lock;
 
 		if (lock)
 			mutex_lock(lock);

  reply	other threads:[~2024-02-29  7:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  5:03 syzbot
2024-02-29  7:20 ` Lizhi Xu [this message]
2024-02-29  7:51   ` syzbot
2024-02-29 11:18 ` Edward Adam Davis
2024-02-29 12:03   ` syzbot
2024-02-29 12:21 ` [PATCH] media: fix " Edward Adam Davis
2024-02-29 12:36   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240229072016.186240-1-lizhi.xu@windriver.com \
    --to=lizhi.xu@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+2622b51b35f91a00ea18@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®