From: Andrew Morton <akpm@linux-foundation.org>
To: Hao Ge <gehao@kylinos.cn>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gehao618@163.com
Subject: Re: [PATCH v2] mm/vmstat: Add order's information for extfrag_index and unusable_index
Date: Thu, 29 Feb 2024 10:40:13 -0800 [thread overview]
Message-ID: <20240229104013.5ed8c1ca9c2dbd0bd5fb571f@linux-foundation.org> (raw)
In-Reply-To: <20240229141443.99408-1-gehao@kylinos.cn>
On Thu, 29 Feb 2024 22:14:43 +0800 Hao Ge <gehao@kylinos.cn> wrote:
> Current cat /sys/kernel/debug/extfrag/extfrag_index and
> /sys/kernel/debug/extfrag/unusable_index is not friendly to userspace.
>
> We should add order's information so that users can clearly understand
> the situation of each order at a glance like pagetypeinfo.
>
> before:
> cat /sys/kernel/debug/extfrag/extfrag_index:
> Node 0, zone DMA32 ...... ...... ...... ......
> Node 0, zone Normal ...... ...... ...... ......
>
> cat /sys/kernel/debug/extfrag/unusable_index:
> Node 0, zone DMA32 ..... ..... ..... .....
> Node 0, zone Normal ..... ..... ..... .....
>
> after:
> cat /sys/kernel/debug/extfrag/extfrag_index:
> Extfrag index at order: 0 1 2 3
> Node 0, zone DMA ...... ...... ...... ......
> Node 0, zone Normal ...... ...... ...... ......
>
> cat /sys/kernel/debug/extfrag/unusable_index:
> Unusable index at order: 0 1 2 3
> Node 0, zone DMA ..... ..... ..... .....
> Node 0, zone Normal ..... ..... ..... .....
>
This may break existing parsers of this file.
And that would be allowed if these files were under debugfs. But
they're under sysfs/debug, where the rules are less clear.
Still, it's unclear to me that the benefit is worth this risk. What do
others think?
next prev parent reply other threads:[~2024-02-29 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 14:14 Hao Ge
2024-02-29 18:40 ` Andrew Morton [this message]
2024-02-29 23:13 ` Hao Ge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229104013.5ed8c1ca9c2dbd0bd5fb571f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gehao618@163.com \
--cc=gehao@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®