From: Mikhail Rudenko <mike.rudenko@gmail.com>
To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Tommaso Merciai <tomm.merciai@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Mikhail Rudenko <mike.rudenko@gmail.com>
Subject: [PATCH v3 14/20] media: i2c: ov4689: Implement manual color balance controls
Date: Thu, 29 Feb 2024 19:53:27 +0300 [thread overview]
Message-ID: <20240229165333.227484-15-mike.rudenko@gmail.com> (raw)
In-Reply-To: <20240229165333.227484-1-mike.rudenko@gmail.com>
The OV4689 sensor has separate red and blue gain settings (up to 4x).
Implement appropriate controls in the driver. Default gain values
are not modified.
Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/i2c/ov4689.c | 23 ++++++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
index 1450db7302b7..6c36fe5f3b44 100644
--- a/drivers/media/i2c/ov4689.c
+++ b/drivers/media/i2c/ov4689.c
@@ -56,6 +56,13 @@
#define OV4689_TIMING_FLIP_BOTH (OV4689_TIMING_FLIP_ARRAY |\
OV4689_TIMING_FLIP_DIGITAL)
+#define OV4689_REG_WB_GAIN_RED CCI_REG16(0x500c)
+#define OV4689_REG_WB_GAIN_BLUE CCI_REG16(0x5010)
+#define OV4689_WB_GAIN_MIN 1
+#define OV4689_WB_GAIN_MAX 0xfff
+#define OV4689_WB_GAIN_STEP 1
+#define OV4689_WB_GAIN_DEFAULT 0x400
+
#define OV4689_REG_TEST_PATTERN CCI_REG8(0x5040)
#define OV4689_TEST_PATTERN_ENABLE 0x80
#define OV4689_TEST_PATTERN_DISABLE 0x0
@@ -632,6 +639,12 @@ static int ov4689_set_ctrl(struct v4l2_ctrl *ctrl)
case V4L2_CID_DIGITAL_GAIN:
cci_write(regmap, OV4689_REG_DIG_GAIN, ctrl->val, &ret);
break;
+ case V4L2_CID_RED_BALANCE:
+ cci_write(regmap, OV4689_REG_WB_GAIN_RED, ctrl->val, &ret);
+ break;
+ case V4L2_CID_BLUE_BALANCE:
+ cci_write(regmap, OV4689_REG_WB_GAIN_BLUE, ctrl->val, &ret);
+ break;
default:
dev_warn(dev, "%s Unhandled id:0x%x, val:0x%x\n",
__func__, ctrl->id, ctrl->val);
@@ -662,7 +675,7 @@ static int ov4689_initialize_controls(struct ov4689 *ov4689)
handler = &ov4689->ctrl_handler;
mode = ov4689->cur_mode;
- ret = v4l2_ctrl_handler_init(handler, 13);
+ ret = v4l2_ctrl_handler_init(handler, 15);
if (ret)
return ret;
@@ -709,6 +722,14 @@ static int ov4689_initialize_controls(struct ov4689 *ov4689)
OV4689_DIG_GAIN_MIN, OV4689_DIG_GAIN_MAX,
OV4689_DIG_GAIN_STEP, OV4689_DIG_GAIN_DEFAULT);
+ v4l2_ctrl_new_std(handler, &ov4689_ctrl_ops, V4L2_CID_RED_BALANCE,
+ OV4689_WB_GAIN_MIN, OV4689_WB_GAIN_MAX,
+ OV4689_WB_GAIN_STEP, OV4689_WB_GAIN_DEFAULT);
+
+ v4l2_ctrl_new_std(handler, &ov4689_ctrl_ops, V4L2_CID_BLUE_BALANCE,
+ OV4689_WB_GAIN_MIN, OV4689_WB_GAIN_MAX,
+ OV4689_WB_GAIN_STEP, OV4689_WB_GAIN_DEFAULT);
+
if (handler->error) {
ret = handler->error;
dev_err(ov4689->dev, "Failed to init controls(%d)\n", ret);
--
2.43.0
next prev parent reply other threads:[~2024-02-29 16:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 16:53 [PATCH v3 00/20] Omnivision OV4689 refactoring and improvements Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 01/20] media: i2c: ov4689: Clean up and annotate the register table Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 02/20] media: i2c: ov4689: Sort register definitions by address Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 03/20] media: i2c: ov4689: Fix typo in a comment Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 04/20] media: i2c: ov4689: CCI conversion Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 05/20] media: i2c: ov4689: Remove i2c_client from ov4689 struct Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 06/20] media: i2c: ov4689: Refactor ov4689_set_ctrl Mikhail Rudenko
2024-03-04 16:49 ` Kieran Bingham
2024-03-04 20:17 ` Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 07/20] media: i2c: ov4689: Use sub-device active state Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 08/20] media: i2c: ov4689: Enable runtime PM before registering sub-device Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 09/20] media: i2c: ov4689: Use runtime PM autosuspend Mikhail Rudenko
2024-03-04 20:45 ` Laurent Pinchart
2024-02-29 16:53 ` [PATCH v3 10/20] media: i2c: ov4689: Remove max_fps field from struct ov4689_mode Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 11/20] media: i2c: ov4689: Make horizontal blanking configurable Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 12/20] media: i2c: ov4689: Implement vflip/hflip controls Mikhail Rudenko
2024-03-04 16:54 ` Kieran Bingham
2024-03-04 20:19 ` Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 13/20] media: i2c: ov4689: Implement digital gain control Mikhail Rudenko
2024-02-29 16:53 ` Mikhail Rudenko [this message]
2024-02-29 16:53 ` [PATCH v3 15/20] media: i2c: ov4689: Move pixel array size out of struct ov4689_mode Mikhail Rudenko
2024-03-04 17:01 ` Kieran Bingham
2024-02-29 16:53 ` [PATCH v3 16/20] media: i2c: ov4689: Set timing registers programmatically Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 17/20] media: i2c: ov4689: Configurable analogue crop Mikhail Rudenko
2024-03-05 14:27 ` Kieran Bingham
2024-03-05 14:35 ` Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 18/20] media: i2c: ov4689: Eliminate struct ov4689_mode Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 19/20] media: i2c: ov4689: Refactor ov4689_s_stream Mikhail Rudenko
2024-03-04 21:31 ` Laurent Pinchart
2024-03-04 21:48 ` Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 20/20] media: i2c: ov4689: Implement 2x2 binning Mikhail Rudenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229165333.227484-15-mike.rudenko@gmail.com \
--to=mike.rudenko@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.stevenson@raspberrypi.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome