mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Goldsworthy <quic_cgoldswo@quicinc.com>
To: Georgi Djakov <djakov@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Georgi Djakov <quic_c_gdjako@quicinc.com>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<will@kernel.org>, <robin.murphy@arm.com>, <joro@8bytes.org>,
	<iommu@lists.linux.dev>, <devicetree@vger.kernel.org>,
	<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
	<robdclark@gmail.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<quic_cgoldswo@quicinc.com>, <quic_sukadev@quicinc.com>,
	<quic_pdaly@quicinc.com>, <quic_sudaraja@quicinc.com>
Subject: Re: [PATCH v5 1/7] dt-bindings: iommu: Add Qualcomm TBU bindings
Date: Thu, 29 Feb 2024 14:24:03 -0800	[thread overview]
Message-ID: <20240229222347.GA918@hu-cgoldswo-sd.qualcomm.com> (raw)
In-Reply-To: <70095e04-eaec-4323-b2ac-2d4d366763d5@kernel.org>

On Thu, Feb 29, 2024 at 10:09:34PM +0200, Georgi Djakov wrote:
> Hi Krzysztof,
> 
> On 29.02.24 19:53, Krzysztof Kozlowski wrote:
> >On 26/02/2024 18:22, Georgi Djakov wrote:
> >>+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >>+%YAML 1.2
> >>+---
> >>+$id: http://devicetree.org/schemas/iommu/qcom,tbu.yaml#
> >>+$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>+
> >>+title: Qualcomm TBU (Translation Buffer Unit)
> >>+
> >>+maintainers:
> >>+  - Georgi Djakov <quic_c_gdjako@quicinc.com>
> >>+
> >>+description:
> >>+  The Qualcomm SMMU500 implementation consists of TCU and TBU. The TBU contains
> >>+  a Translation Lookaside Buffer (TLB) that caches page tables. TBUs provides
> >>+  debug features to trace and trigger debug transactions. There are multiple TBU
> >>+  instances with each client core.
> >>+
> >>+properties:
> >>+  compatible:
> >>+    const: qcom,qsmmuv500-tbu
> >
> >Why we don't have SoC specific compatibles? If that's for SDM845, then
> >it should be qcom,sdm845-tbu or qcom,sdm845-qsmmuv500-tbu
> >
> 
> Because they should be all compatible (as registers). Adding a SoC compatible
> might get overly-specific, but i can also see the benefits in that, so ok will
> do it!
> 

Hi Krzysztof,

JFYI that the TBUs are used on our mobile SoCs going up until the SoC
we commercialized in early 2022, Snapdragon 8 Gen 1. Including SDM845
there are three more premium tier SoCs using TBUs plus all of their
value-tier derivatives.  There will also be prior generation premium
tier SoCs along with their derivatives that use the TBU as well. Does
it make sense to have a target-specific compatible string given this? 

Thanks,

Chris.


  reply	other threads:[~2024-02-29 22:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 17:22 [PATCH v5 0/7] Add support for Translation Buffer Units Georgi Djakov
2024-02-26 17:22 ` [PATCH v5 1/7] dt-bindings: iommu: Add Qualcomm TBU bindings Georgi Djakov
2024-02-29 17:53   ` Krzysztof Kozlowski
2024-02-29 20:09     ` Georgi Djakov
2024-02-29 22:24       ` Chris Goldsworthy [this message]
2024-03-01  6:32         ` Krzysztof Kozlowski
2024-02-29 17:59   ` Krzysztof Kozlowski
2024-02-29 20:17     ` Georgi Djakov
2024-02-29 18:01   ` Krzysztof Kozlowski
2024-02-26 17:22 ` [PATCH v5 2/7] iommu/arm-smmu-qcom-tbu: Add Qualcomm TBU driver Georgi Djakov
2024-02-26 17:22 ` [PATCH v5 3/7] iommu/arm-smmu: Allow using a threaded handler for context interrupts Georgi Djakov
2024-02-26 17:22 ` [PATCH v5 4/7] iommu/arm-smmu-qcom: Use a custom context fault handler for sdm845 Georgi Djakov
2024-02-26 17:22 ` [PATCH v5 5/7] arm64: dts: qcom: sdm845: Add DT nodes for the TBUs Georgi Djakov
2024-02-26 17:22 ` [PATCH v5 6/7] iommu/arm-smmu-qcom: Use the custom fault handler on more platforms Georgi Djakov
2024-02-26 17:22 ` [PATCH v5 7/7] arm64: dts: qcom: sc7280: Add DT nodes for the TBUs Georgi Djakov
2024-02-29 17:55   ` Krzysztof Kozlowski
2024-02-29 20:14     ` Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240229222347.GA918@hu-cgoldswo-sd.qualcomm.com \
    --to=quic_cgoldswo@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_c_gdjako@quicinc.com \
    --cc=quic_pdaly@quicinc.com \
    --cc=quic_sudaraja@quicinc.com \
    --cc=quic_sukadev@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®