mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	vaclav.zindulka@tlapnet.cz, Jiri Pirko <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Coco Li <lixiaoyan@google.com>, David Ahern <dsahern@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] tracing/net_sched: Fix tracepoints that save qdisc_dev() as a string
Date: Fri, 1 Mar 2024 15:01:53 -0500	[thread overview]
Message-ID: <20240301150153.36e5bf60@gandalf.local.home> (raw)
In-Reply-To: <CAM0EoMkOgTezVLnN7f1GoXTURQ73LmXjHnBjQBSBRPnv58K-VQ@mail.gmail.com>

On Fri, 1 Mar 2024 14:24:17 -0500
Jamal Hadi Salim <jhs@mojatatu.com> wrote:

> > Fixes: a34dac0b90552 ("net_sched: add tracepoints for qdisc_reset() and qdisc_destroy()")
> > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>  
> 
> Should this be targeting the net tree?

I was going to say that I need this for my work, but my work is aimed at
the next merge window, but this should go into the kernel now and be marked
for stable. So yes, it probably should go through the net tree.

Do I need to resubmit it?

> Otherwise, LGTM. Just wondering - this worked before because "name"
> was the first field?

Looks like it. See commit 43a71cd66b9c0 ("net-device: reorganize net_device
fast path variables")

I wonder if there's anything else that uses a pointer to struct net_device
thinking it can just be switched to find the name?

> 
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>

Thanks,

-- Steve

  reply	other threads:[~2024-03-01 19:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29 19:34 Steven Rostedt
2024-03-01 19:24 ` Jamal Hadi Salim
2024-03-01 20:01   ` Steven Rostedt [this message]
2024-03-01 21:07     ` Jamal Hadi Salim
2024-03-04  9:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301150153.36e5bf60@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixiaoyan@google.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vaclav.zindulka@tlapnet.cz \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®