Re: [PATCH v2] firmware: microchip: Fix over-requested allocation size

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

On Mon, Mar 04, 2024 at 06:16:53PM +0800, Dawei Li wrote:
> cocci warnings: (new ones prefixed by >>)
> >> drivers/firmware/microchip/mpfs-auto-update.c:387:72-78:
>    ERROR: application of sizeof to pointer
>    drivers/firmware/microchip/mpfs-auto-update.c:170:72-78:
>    ERROR: application of sizeof to pointer
> 
> response_msg is a pointer to u32, so the size of element it points to is
> supposed to be a multiple of sizeof(u32), rather than sizeof(u32 *).
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202403040516.CYxoWTXw-lkp@intel.com/
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
> ---
> 
> V1 -> V2:
> sizeof(u32)->sizeof(*response_msg) 

Thanks for the quick respin. I'll send this as 6.9 material cos of the
proximity to the merge window and the fact that we just over-allocate
here. Thanks!

I added a Fixes: tag when I applied this, you should add those in the
future. I should've mentioned this earlier but forgot.

Thanks,
Conor.

https://git.kernel.org/conor/c/af1e0a7d39f98c0dea1b186a76fcee7da6a5f7bc


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]