From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9903487BE for ; Mon, 4 Mar 2024 15:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709566164; cv=none; b=cXLxjFEbIxmRCWtS//uWZhjx5kSQkBCpn1xOrvGtvJHZuZ8ZQSIAPpgIxXQVLAHGW4NGSiBwo5+WmhRclJi9rAkUK7GJ1Z3o6yeAyQmQP5UAe3MmguCpA1fxzgHOSyU2MBI03g9qxqhljokP62STwvKqKfi2vEOCj72Up1s8U/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709566164; c=relaxed/simple; bh=vconTWJf3hkrQzDYTc60aASNd6jpDkr3/nMsFeCdX/M=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Ouk49f3FOxeOYjD5TKLlp0ErW+u1+c5DuYOx1QR91f44QxWrqHMI8xrhZ4t5WcnnZe4gue5YC2aKFbunCrMA8YlXkHDB71r3rkHCkSh8dLEBmNvY8hPA8XM3xP8KvMTtPOS2vmwF1b5p4ffEtNH9MzDfW+/aDCsgIUpd1OjdGEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=EtIEczIv; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="EtIEczIv" Received: by mail.gandi.net (Postfix) with ESMTPSA id 9D3021C0005; Mon, 4 Mar 2024 15:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709566159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p4VyPuPWctRMKsSKKnHnhgfKmx3KohaktZO2hx+9UzE=; b=EtIEczIvozkpeBA10mLGWbF3Mk0mc6A95rd4ktHrEYfHCtyJ5F71a4Mb/71vIQa6kYYZuQ w9LgsvhriTyj8KGZ1NDCTZjDylVQ5e7etcqxvSVo/Yyq/tADXkI8f/T/G47012vyBTUwnb B9SLAQdtPEvfHaZugC/WpIJndSulgj0vPpsyJLAFDH3Uu3mIK7n93tKaNP245gdDKVblXh C/F4H02hQAvhR7L2cvcz7NcnLQfKfHQV7KrbTTtrANkejLmuxmWpfDabqHeoU9o77CfATc E+juXtwsyKsfsWDXRzHcyxE6IIQBqZzHfcIpRNJwmcRRBLACKxcuZ6MpvCf7GA== From: Louis Chauvet Subject: [PATCH v4 00/14] drm/vkms: Reimplement line-per-line pixel conversion for plane reading Date: Mon, 04 Mar 2024 16:28:05 +0100 Message-Id: <20240304-yuv-v4-0-76beac8e9793@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAIbo5WUC/2XNQQ6DIBAF0KsY1qXBwULtqvdougCESmKhASU1x rsXdaPp8v/M+zOhqIPVEd2KCQWdbLTe5VCdCqRa4V4a2yZnBAQqAqTE45BwSSlvatLUF85QvpQ iaiyDcKrNt27oulx+gjb2u04/njm3NvY+jOunVC7tcTSVmGCqBOXMAGcU7tL7vrPurPwbLQsJd gropiArIZjUcAUuJf9XdK/YpmhWxjAGhtR11cijmuf5Bw20BCUZAQAA To: Rodrigo Siqueira , Melissa Wen , =?utf-8?q?Ma=C3=ADra_Canal?= , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , arthurgrillo@riseup.net, Jonathan Corbet , pekka.paalanen@haloniitty.fi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com, Louis Chauvet X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=8415; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=vconTWJf3hkrQzDYTc60aASNd6jpDkr3/nMsFeCdX/M=; b=owEBbQKS/ZANAwAIASCtLsZbECziAcsmYgBl5ejKSkW5zpF9YuBBe/BTUGRlKz3pzdJMCieHG1pT hiv0gkKJAjMEAAEIAB0WIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCZeXoygAKCRAgrS7GWxAs4hj3D/ 9eACMyg9HBiq7pJAfprAQKwbSZdVmwH3KxJN8FeOnLOugfSMaxU4axep1gBRvt2F6JfJU3GxaiNfO+ phLqUZ355uZgflAH1X5C17AiR3owGznf9VeRZJ3bZXkZrLVxD4rm54wNGL160Uf62GasmMMImkR4KA FGthmc6mswWtuq3OGN+7kPAErGWXbBnwhDqiGoW/xEB11ivCxJpcO+PaDZ1HB7no0Wsdtd37S2UUDP Dik0LL+iyGSEhMBvFDHNYWXllh6+g6NlMBmGZHh5OHTe/+dKPIK9O8ZpMqkfcrgISPdzPuyX1Z5Rkz UkeCf0NDRqmFF242EV/cWATJpJ1ubSRfEvu+wgVbAzITpkVC55+Mm6hIIjZPrwCqs50wt3hfesv6N6 KxtiScAm1hWy/eZmQaNG3tXHlcj2G8k5Wfbomutyt0LVN+P7aaJKKFcFErg6442zvAbh6nHfOhDpHx 0PixxZev/+AU9iL8RZ5J4RIOxcrNFQwWlSNfongODLpqeCr6Ufp20t6iRMjD0DYEd2sqxyUtaVZdGr s0XDPQIphA4vnlQboYJtuXSHGG9BTzjLa7QOJsgubU4eQgcHfuvSczno0kMn7IG6+zlzDamnN95jFc 6wT0/jIJV16Bs8QQQhHtsnc3y/D8G13GErS9kWlYU5Hk+SKimqnp3y5CoiMA== X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-GND-Sasl: louis.chauvet@bootlin.com This patchset is the second version of [1]. It is almost a complete rewrite to use a line-by-line algorithm for the composition. It can be divided in three parts: - PATCH 1 to 4: no functional change is intended, only some formatting and documenting (PATCH 2 is taken from [2]) - PATCH 5 to 8: Some preparation work not directly related to the line-by-line algorithm - PATCH 9: main patch for this series, it reintroduce the line-by-line algorithm - PATCH 10 to 13: taken from Arthur's series [2], with sometimes adaptation to use the pixel-by-pixel algorithm. The PATCH 9 aims to restore the line-by-line pixel reading algorithm. It was introduced in 8ba1648567e2 ("drm: vkms: Refactor the plane composer to accept new formats") but removed in 8ba1648567e2 ("drm: vkms: Refactor the plane composer to accept new formats") in a over-simplification effort. At this time, nobody noticed the performance impact of this commit. After the first iteration of my series, poeple notice performance impact, and it was the case. Pekka suggested to reimplement the line-by-line algorithm. Expiriments on my side shown great improvement for the line-by-line algorithm, and the performances are the same as the original line-by-line algorithm. I targeted my effort to make the code working for all the rotations and translations. The usage of helpers from drm_rect_* avoid reimplementing existing logic. The only "complex" part remaining is the clipping of the coordinate to avoid reading/writing outside of src/dst. Thus I added a lot of comments to help when someone will want to add some features (framebuffer resizing for example). The YUV part is not mandatory for this series, but as my first effort was to help the integration of YUV, I decided to rebase Arthur's series on mine to help. I took [3], [4], [5] and [6] and adapted them to use the line-by-line reading. They were also updated to use 32.32 fixed point values for yuv conversion instead of 8.8 fixed points. My series was mainly tested with: - kms_plane (for color conversions) - kms_rotation_crc (for rotations of planes) - kms_cursor_crc (for translations) The benchmark used to measure the improvment was done with: - kms_fb_stress [1]: https://lore.kernel.org/r/20240201-yuv-v1-0-3ca376f27632@bootlin.com [2]: https://lore.kernel.org/all/20240110-vkms-yuv-v2-0-952fcaa5a193@riseup.net/ [3]: https://lore.kernel.org/all/20240110-vkms-yuv-v2-3-952fcaa5a193@riseup.net/ [4]: https://lore.kernel.org/all/20240110-vkms-yuv-v2-5-952fcaa5a193@riseup.net/ [5]: https://lore.kernel.org/all/20240110-vkms-yuv-v2-6-952fcaa5a193@riseup.net/ [6]: https://lore.kernel.org/all/20240110-vkms-yuv-v2-7-952fcaa5a193@riseup.net/ To: Rodrigo Siqueira To: Melissa Wen To: Maíra Canal To: Haneen Mohammed To: Daniel Vetter To: Maarten Lankhorst To: Maxime Ripard To: Thomas Zimmermann To: David Airlie To: arthurgrillo@riseup.net To: Jonathan Corbet To: pekka.paalanen@haloniitty.fi Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Cc: jeremie.dautheribes@bootlin.com Cc: miquel.raynal@bootlin.com Cc: thomas.petazzoni@bootlin.com Cc: seanpaul@google.com Cc: marcheu@google.com Cc: nicolejadeyee@google.com Signed-off-by: Louis Chauvet Note: after my changes, those tests seems to pass, so [7] may need updating (I did not check, it was maybe already the case): - kms_cursor_legacy@flip-vs-cursor-atomic - kms_pipe_crc_basic@nonblocking-crc - kms_pipe_crc_basic@nonblocking-crc-frame-sequence - kms_writeback@writeback-pixel-formats - kms_writeback@writeback-invalid-parameters - kms_flip@flip-vs-absolute-wf_vblank-interruptible And those tests pass, I did not investigate why the runners fails: - kms_flip@flip-vs-expired-vblank-interruptible - kms_flip@flip-vs-expired-vblank - kms_flip@plain-flip-fb-recreate - kms_flip@plain-flip-fb-recreate-interruptible - kms_flip@plain-flip-ts-check-interruptible - kms_cursor_legacy@cursorA-vs-flipA-toggle - kms_pipe_crc_basic@nonblocking-crc - kms_prop_blob@invalid-get-prop - kms_flip@flip-vs-absolute-wf_vblank-interruptible - kms_invalid_mode@zero-hdisplay - kms_invalid_mode@bad-vtotal - kms_cursor_crc.* (everything is SUCCEED or SKIP, but no fails) [7]: https://lore.kernel.org/all/20240201065346.801038-1-vignesh.raman@collabora.com/ Changes in v4: - PATCH 3/14: Update comments for get_pixel_* functions - PATCH 4/14: Add WARN when trying to get unsupported pixel_* functions - PATCH 5/14: Create dummy pixel reader/writer to avoid NULL function pointers and kernel OOPS - PATCH 6/14: Added the usage of const pointers when needed - PATCH 7/14: Extraction of pixel accessors modification - PATCH 8/14: Extraction of the blending function modification - PATCH 9/14: Extraction of the pixel_read_direction enum - PATCH 10/14: Update direction_for_rotation documentation - PATCH 10/14: Rename conversion functions to be explicit - PATCH 10/14: Replace while(count) by while(out_pixel