From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: kernel@collabora.com, linux-kernel@vger.kernel.org,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Subject: [PATCH 0/3] device: core: Adjust device probe log messages to ease error detection
Date: Tue, 05 Mar 2024 17:21:35 -0500 [thread overview]
Message-ID: <20240305-device-probe-error-v1-0-a06d8722bf19@collabora.com> (raw)
This series adjusts log message's log levels and helper functions to
make it easier to detect issues with the probe of devices.
This is the rationale:
- The dev_* printk variants should be used to log information related to
the probe of a device so that the messages get the device's metadata
attached and can easily be correlated to it.
- Issues in the probe of a device should be logged at the error level.
If it is likely that an issue has ocurred, but not guaranteed, log at
the warning level.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Nícolas F. R. A. Prado (3):
driver: core: Log probe failure as error and with device metadata
driver: core: Use dev_* instead of pr_* so device metadata is added
device: core: Log warning for devices pending deferred probe on timeout
drivers/base/dd.c | 32 +++++++++++++++-----------------
1 file changed, 15 insertions(+), 17 deletions(-)
---
base-commit: 11afac187274a6177a7ac82997f8691c0f469e41
change-id: 20240305-device-probe-error-ec99e7bdd2d3
Best regards,
--
Nícolas F. R. A. Prado <nfraprado@collabora.com>
next reply other threads:[~2024-03-05 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 22:21 Nícolas F. R. A. Prado [this message]
2024-03-05 22:21 ` [PATCH 1/3] driver: core: Log probe failure as error and with device metadata Nícolas F. R. A. Prado
2024-03-05 22:21 ` [PATCH 2/3] driver: core: Use dev_* instead of pr_* so device metadata is added Nícolas F. R. A. Prado
2024-03-05 22:21 ` [PATCH 3/3] device: core: Log warning for devices pending deferred probe on timeout Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305-device-probe-error-v1-0-a06d8722bf19@collabora.com \
--to=nfraprado@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®