From: Stuart Henderson <stuarth@opensource.cirrus.com>
To: <broonie@kernel.org>, <shengjiu.wang@gmail.com>, <Xiubo.Lee@gmail.com>
Cc: <patches@opensource.cirrus.com>, <linux-sound@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
"Stuart Henderson" <stuarth@opensource.cirrus.com>
Subject: [PATCH 3/5] ASoC: fsl: Fix up mclk_id for fsl,imx-audio-wm8962
Date: Wed, 6 Mar 2024 16:14:37 +0000 [thread overview]
Message-ID: <20240306161439.1385643-3-stuarth@opensource.cirrus.com> (raw)
In-Reply-To: <20240306161439.1385643-1-stuarth@opensource.cirrus.com>
wm8962_set_fll is currently incorrect, and largely ignores the source
parameter. This patch fixes this use of wm8962_set_fll in preparation
for fixing this. Previously we were using WM8962_SYSCLK_MCLK (0), but
wm8962_set_fll ends up using the fll_id (in this case WM8962_FLL = 1).
Change this to WM8962_FLL_MCLK (1) instead.
Signed-off-by: Stuart Henderson <stuarth@opensource.cirrus.com>
---
sound/soc/fsl/fsl-asoc-card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
index bc07f26ba303..2781fd8d198e 100644
--- a/sound/soc/fsl/fsl-asoc-card.c
+++ b/sound/soc/fsl/fsl-asoc-card.c
@@ -656,7 +656,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
priv->card.num_dapm_routes = ARRAY_SIZE(audio_map_tx);
} else if (of_device_is_compatible(np, "fsl,imx-audio-wm8962")) {
codec_dai_name = "wm8962";
- priv->codec_priv.mclk_id = WM8962_SYSCLK_MCLK;
+ priv->codec_priv.mclk_id = WM8962_FLL_MCLK;
priv->codec_priv.fll_id = WM8962_SYSCLK_FLL;
priv->codec_priv.pll_id = WM8962_FLL;
priv->dai_fmt |= SND_SOC_DAIFMT_CBP_CFP;
--
2.39.2
next prev parent reply other threads:[~2024-03-06 16:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 16:14 [PATCH 1/5] ASoC: wm8962: Enable oscillator if selecting WM8962_FLL_OSC Stuart Henderson
2024-03-06 16:14 ` [PATCH 2/5] ASoC: wm8962: Enable both SPKOUTR_ENA and SPKOUTL_ENA in mono mode Stuart Henderson
2024-03-06 16:47 ` Mark Brown
2024-03-06 16:14 ` Stuart Henderson [this message]
2024-03-06 16:14 ` [PATCH 4/5] ASoC: wm8962: Fix wm8962_set_fll to use source instead of fll_id Stuart Henderson
2024-03-06 16:46 ` Mark Brown
2024-03-06 16:14 ` [PATCH 5/5] ASoC: wm8962: Fix up incorrect error message in wm8962_set_fll Stuart Henderson
2024-03-06 16:24 ` [PATCH 1/5] ASoC: wm8962: Enable oscillator if selecting WM8962_FLL_OSC Mark Brown
2024-03-06 22:13 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306161439.1385643-3-stuarth@opensource.cirrus.com \
--to=stuarth@opensource.cirrus.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=shengjiu.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®