From: Bhargav Raviprakash <bhargav.r@ltts.com>
To: broonie@kernel.org
Cc: arnd@arndb.de, bhargav.r@ltts.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, eblanc@baylibre.com,
gregkh@linuxfoundation.org, jpanis@baylibre.com,
kristo@kernel.org, krzysztof.kozlowski+dt@linaro.org,
lee@kernel.org, lgirdwood@gmail.com, linus.walleij@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com, nm@ti.com,
robh+dt@kernel.org, vigneshr@ti.com
Subject: Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators
Date: Thu, 7 Mar 2024 14:48:23 +0530 [thread overview]
Message-ID: <20240307091823.171504-1-bhargav.r@ltts.com> (raw)
In-Reply-To: <6fa04f9a-2904-4955-a219-d4962b8fe41b@sirena.org.uk>
Hi,
On Thu, 29 Feb 2024 14:49:16 +0000, Mark Brown wrote:
> On Thu, Feb 29, 2024 at 03:42:50PM +0100, Esteban Blanc wrote:
> > On Fri Feb 23, 2024 at 10:36 AM CET, Bhargav Raviprakash wrote:
>
> > > + /* Number of interrupts supported by each voltage source */
> > > + interrupt_cnt = (tps->chip_id == TPS6594) ?
> > > + ARRAY_SIZE(tps6594_buck1_irq_types) :
> > > + ARRAY_SIZE(tps65224_buck1_irq_types);
>
> > The comment is not adding anything, the name is clear and ARRAY_SIZE is
> > quite explicit.
>
> Also please don't abuse the ternery operator like this, write normal
> conditionals or for a case like this where we may get more options in
> future use switch statements.
Got it! will fix it in the next version.
Regards,
Bhargav
next prev parent reply other threads:[~2024-03-07 9:18 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 9:36 [PATCH v2 00/14] Add support for TI TPS65224 PMIC Bhargav Raviprakash
2024-02-23 9:36 ` [PATCH v2 01/14] mfd: tps6594: Add register definitions " Bhargav Raviprakash
2024-02-26 11:07 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 02/14] mfd: tps6594: use volatile_table instead of volatile_reg Bhargav Raviprakash
2024-02-26 11:15 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 03/14] mfd: tps6594: add regmap config in match data Bhargav Raviprakash
2024-02-26 11:35 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 04/14] dt-bindings: mfd: ti,tps6594: Add TI TPS65224 PMIC Bhargav Raviprakash
2024-02-23 18:37 ` Conor Dooley
2024-02-23 9:36 ` [PATCH v2 05/14] mfd: tps6594-i2c: Add TI TPS65224 PMIC I2C Bhargav Raviprakash
2024-02-26 11:40 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 06/14] mfd: tps6594-spi: Add TI TPS65224 PMIC SPI Bhargav Raviprakash
2024-02-26 11:52 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 07/14] mfd: tps6594-core: Add TI TPS65224 PMIC core Bhargav Raviprakash
2024-02-26 12:17 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 08/14] misc: tps6594-pfsm: Add TI TPS65224 PMIC PFSM Bhargav Raviprakash
2024-02-26 12:43 ` Julien Panis
2024-03-07 9:13 ` Bhargav Raviprakash
2024-02-23 9:36 ` [PATCH v2 09/14] misc: tps6594-esm: reversion check limited to TPS6594 family Bhargav Raviprakash
2024-02-26 12:56 ` Julien Panis
2024-02-23 9:36 ` [PATCH v2 10/14] misc: tps6594-esm: use regmap_field Bhargav Raviprakash
2024-02-23 9:36 ` [PATCH v2 11/14] misc: tps6594-esm: Add TI TPS65224 PMIC ESM Bhargav Raviprakash
2024-02-23 9:36 ` [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators Bhargav Raviprakash
2024-02-29 13:58 ` Mark Brown
2024-03-07 9:15 ` Bhargav Raviprakash
2024-02-29 14:42 ` Esteban Blanc
2024-02-29 14:49 ` Mark Brown
2024-03-07 9:18 ` Bhargav Raviprakash [this message]
2024-03-07 9:17 ` Bhargav Raviprakash
2024-02-23 9:37 ` [PATCH v2 13/14] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO Bhargav Raviprakash
2024-02-29 13:24 ` Linus Walleij
2024-03-07 9:19 ` Bhargav Raviprakash
2024-03-07 9:36 ` Julien Panis
2024-02-29 13:56 ` Esteban Blanc
2024-02-23 9:37 ` [PATCH v2 14/14] arch: arm64: dts: ti: k3-am62p5-sk: Add TPS65224 PMIC support in AM62P dts Bhargav Raviprakash
2024-02-29 17:49 ` [PATCH v2 00/14] Add support for TI TPS65224 PMIC Lee Jones
2024-03-07 9:47 ` Bhargav Raviprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307091823.171504-1-bhargav.r@ltts.com \
--to=bhargav.r@ltts.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eblanc@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jpanis@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.nirmaladevi@ltts.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®