From: Colin Ian King <colin.i.king@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
u.kleine-koenig@pengutronix.de, linux-usb@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][next] usb: gadget: net2272: remove redundant variable irqflags
Date: Thu, 7 Mar 2024 10:51:35 +0000 [thread overview]
Message-ID: <20240307105135.1981060-1-colin.i.king@gmail.com> (raw)
The variable irqflags is being initialized and being bit-or'd with
values but it is never read afterwards. The variable is redundant
and can be removed.
Cleans up clang scan build warning:
drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags'
set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/usb/gadget/udc/net2272.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
index 12e76bb62c20..afd2a836be6d 100644
--- a/drivers/usb/gadget/udc/net2272.c
+++ b/drivers/usb/gadget/udc/net2272.c
@@ -2607,7 +2607,6 @@ net2272_plat_probe(struct platform_device *pdev)
{
struct net2272 *dev;
int ret;
- unsigned int irqflags;
resource_size_t base, len;
struct resource *iomem, *iomem_bus, *irq_res;
@@ -2623,16 +2622,6 @@ net2272_plat_probe(struct platform_device *pdev)
if (IS_ERR(dev))
return PTR_ERR(dev);
- irqflags = 0;
- if (irq_res->flags & IORESOURCE_IRQ_HIGHEDGE)
- irqflags |= IRQF_TRIGGER_RISING;
- if (irq_res->flags & IORESOURCE_IRQ_LOWEDGE)
- irqflags |= IRQF_TRIGGER_FALLING;
- if (irq_res->flags & IORESOURCE_IRQ_HIGHLEVEL)
- irqflags |= IRQF_TRIGGER_HIGH;
- if (irq_res->flags & IORESOURCE_IRQ_LOWLEVEL)
- irqflags |= IRQF_TRIGGER_LOW;
-
base = iomem->start;
len = resource_size(iomem);
if (iomem_bus)
--
2.39.2
next reply other threads:[~2024-03-07 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 10:51 Colin Ian King [this message]
2024-03-07 16:51 ` Uwe Kleine-König
2024-03-07 17:29 ` Alan Stern
2024-03-07 17:46 ` Colin King (gmail)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307105135.1981060-1-colin.i.king@gmail.com \
--to=colin.i.king@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®