From: Wenchao Hao <haowenchao2@huawei.com>
To: "James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Wenchao Hao <haowenchao2@huawei.com>, <louhongxiang@huawei.com>
Subject: [PATCH v4 2/3] scsi: scsi_error: Fix wrong statistic when print error info
Date: Thu, 7 Mar 2024 22:43:10 +0800 [thread overview]
Message-ID: <20240307144311.73735-3-haowenchao2@huawei.com> (raw)
In-Reply-To: <20240307144311.73735-1-haowenchao2@huawei.com>
shost_for_each_device() would skip devices which is in progress of
removing, so commands of these devices would be ignored in
scsi_eh_prt_fail_stats().
Fix this issue by using shost_for_each_device_include_deleted()
to iterate devices in scsi_eh_prt_fail_stats().
Signed-off-by: Wenchao Hao <haowenchao2@huawei.com>
---
drivers/scsi/scsi_error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 612489afe8d2..a61fd8af3b1f 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -409,7 +409,7 @@ static inline void scsi_eh_prt_fail_stats(struct Scsi_Host *shost,
int cmd_cancel = 0;
int devices_failed = 0;
- shost_for_each_device(sdev, shost) {
+ shost_for_each_device_include_deleted(sdev, shost) {
list_for_each_entry(scmd, work_q, eh_entry) {
if (scmd->device == sdev) {
++total_failures;
--
2.32.0
next prev parent reply other threads:[~2024-03-07 14:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 14:43 [PATCH v4 0/3] SCSI: Fix issues between removing device and error handle Wenchao Hao
2024-03-07 14:43 ` [PATCH v4 1/3] scsi: core: Add new helper to iterate all devices of host Wenchao Hao
2024-03-07 14:43 ` Wenchao Hao [this message]
2024-03-07 14:43 ` [PATCH v4 3/3] scsi: scsi_error: Fix device reset is not triggered Wenchao Hao
2024-03-26 6:37 ` [PATCH v4 0/3] SCSI: Fix issues between removing device and error handle Wenchao Hao
2024-04-12 2:07 ` Wenchao Hao
2024-04-15 15:07 ` Markus Elfring
2024-04-17 15:00 ` Wenchao Hao
2024-04-17 15:06 ` Julia Lawall
2024-04-17 15:18 ` Wenchao Hao
2024-04-17 15:29 ` Wenchao Hao
2024-04-17 15:48 ` [v4 " Markus Elfring
2024-04-17 16:39 ` Wenchao Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307144311.73735-3-haowenchao2@huawei.com \
--to=haowenchao2@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=louhongxiang@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®