From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Shuah Khan <shuah@kernel.org>,
Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: kernel@collabora.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] selftests: x86: conform test to TAP format output
Date: Thu, 7 Mar 2024 23:37:06 +0500 [thread overview]
Message-ID: <20240307183708.2857513-1-usama.anjum@collabora.com> (raw)
Conform the layout, informational and status messages to TAP. No
functional change is intended other than the layout of output messages.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
tools/testing/selftests/x86/vdso_restorer.c | 29 +++++++++------------
1 file changed, 12 insertions(+), 17 deletions(-)
diff --git a/tools/testing/selftests/x86/vdso_restorer.c b/tools/testing/selftests/x86/vdso_restorer.c
index fe99f24341554..f621167424a9c 100644
--- a/tools/testing/selftests/x86/vdso_restorer.c
+++ b/tools/testing/selftests/x86/vdso_restorer.c
@@ -21,6 +21,7 @@
#include <unistd.h>
#include <syscall.h>
#include <sys/syscall.h>
+#include "../kselftest.h"
/* Open-code this -- the headers are too messy to easily use them. */
struct real_sigaction {
@@ -44,17 +45,19 @@ static void handler_without_siginfo(int sig)
int main()
{
- int nerrs = 0;
struct real_sigaction sa;
+ ksft_print_header();
+ ksft_set_plan(2);
+
void *vdso = dlopen("linux-vdso.so.1",
RTLD_LAZY | RTLD_LOCAL | RTLD_NOLOAD);
if (!vdso)
vdso = dlopen("linux-gate.so.1",
RTLD_LAZY | RTLD_LOCAL | RTLD_NOLOAD);
if (!vdso) {
- printf("[SKIP]\tFailed to find vDSO. Tests are not expected to work.\n");
- return 0;
+ ksft_print_msg("[SKIP]\tFailed to find vDSO. Tests are not expected to work.\n");
+ return KSFT_SKIP;
}
memset(&sa, 0, sizeof(sa));
@@ -62,21 +65,16 @@ int main()
sa.flags = SA_SIGINFO;
sa.restorer = NULL; /* request kernel-provided restorer */
- printf("[RUN]\tRaise a signal, SA_SIGINFO, sa.restorer == NULL\n");
+ ksft_print_msg("Raise a signal, SA_SIGINFO, sa.restorer == NULL\n");
if (syscall(SYS_rt_sigaction, SIGUSR1, &sa, NULL, 8) != 0)
err(1, "raw rt_sigaction syscall");
raise(SIGUSR1);
- if (handler_called) {
- printf("[OK]\tSA_SIGINFO handler returned successfully\n");
- } else {
- printf("[FAIL]\tSA_SIGINFO handler was not called\n");
- nerrs++;
- }
+ ksft_test_result(handler_called, "SA_SIGINFO handler returned\n");
- printf("[RUN]\tRaise a signal, !SA_SIGINFO, sa.restorer == NULL\n");
+ ksft_print_msg("Raise a signal, !SA_SIGINFO, sa.restorer == NULL\n");
sa.flags = 0;
sa.handler = handler_without_siginfo;
@@ -86,10 +84,7 @@ int main()
raise(SIGUSR1);
- if (handler_called) {
- printf("[OK]\t!SA_SIGINFO handler returned successfully\n");
- } else {
- printf("[FAIL]\t!SA_SIGINFO handler was not called\n");
- nerrs++;
- }
+ ksft_test_result(handler_called, "SA_SIGINFO handler returned\n");
+
+ ksft_finished();
}
--
2.39.2
next reply other threads:[~2024-03-07 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 18:37 Muhammad Usama Anjum [this message]
2024-03-25 7:07 ` Muhammad Usama Anjum
2024-04-04 11:49 ` Muhammad Usama Anjum
2024-04-14 13:21 ` Muhammad Usama Anjum
2024-04-22 12:38 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307183708.2857513-1-usama.anjum@collabora.com \
--to=usama.anjum@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®