From: Vishal Chourasia <vishalc@linux.ibm.com>
To: peterz@infradead.org, linux-kernel@vger.kernel.org
Cc: Vishal Chourasia <vishalc@linux.ibm.com>
Subject: [RFC 1/1] sched: Deprecate DOUBLE_TICK feature
Date: Fri, 8 Mar 2024 10:53:04 +0530 [thread overview]
Message-ID: <20240308052304.1835792-2-vishalc@linux.ibm.com> (raw)
In-Reply-To: <20240308052304.1835792-1-vishalc@linux.ibm.com>
The DOUBLE_TICK feature, introduced to manage the interaction between
periodic and high-resolution timer ticks, has become obsolete following
the removal of the check_preempt_tick method in commit 5e963f2bd465
("sched/fair: Commit to EEVDF"). This change rendered the DOUBLE_TICK
check in entity_tick pointless, as it no longer influences scheduling
decisions.
This commit removes the DOUBLE_TICK feature flag, simplifying the
scheduler code and eliminating a now-unnecessary check.
Signed-off-by: Vishal Chourasia <vishalc@linux.ibm.com>
---
kernel/sched/fair.c | 6 ------
kernel/sched/features.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 533547e3c90a..73e1372d1a0d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5510,12 +5510,6 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr, int queued)
resched_curr(rq_of(cfs_rq));
return;
}
- /*
- * don't let the period tick interfere with the hrtick preemption
- */
- if (!sched_feat(DOUBLE_TICK) &&
- hrtimer_active(&rq_of(cfs_rq)->hrtick_timer))
- return;
#endif
}
diff --git a/kernel/sched/features.h b/kernel/sched/features.h
index 143f55df890b..f2671bf8d6ab 100644
--- a/kernel/sched/features.h
+++ b/kernel/sched/features.h
@@ -28,7 +28,6 @@ SCHED_FEAT(WAKEUP_PREEMPTION, true)
SCHED_FEAT(HRTICK, false)
SCHED_FEAT(HRTICK_DL, false)
-SCHED_FEAT(DOUBLE_TICK, false)
/*
* Decrement CPU capacity based on time not spent running tasks
--
2.43.0
prev parent reply other threads:[~2024-03-08 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 5:23 [RFC 0/1] " Vishal Chourasia
2024-03-08 5:23 ` Vishal Chourasia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308052304.1835792-2-vishalc@linux.ibm.com \
--to=vishalc@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®