From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshan.ljs@antgroup.com>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: [PATCH 2/4] workqueue: Reorder the fields in struct workqueue_attrs
Date: Fri, 8 Mar 2024 17:42:51 +0800 [thread overview]
Message-ID: <20240308094253.2104-3-jiangshanlai@gmail.com> (raw)
In-Reply-To: <20240308094253.2104-1-jiangshanlai@gmail.com>
From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
So that its size is reduced from 40 to 32 in 64bit kernel, and it can be
saved more when allocated with kmalloc() in alloc_workqueue_attrs().
Signed-off-by: Lai Jiangshan <jiangshan.ljs@antgroup.com>
---
include/linux/workqueue.h | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 158784dd189a..c885a5f6bb93 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -145,13 +145,15 @@ struct workqueue_attrs {
int nice;
/**
- * @cpumask: allowed CPUs
+ * @affn_strict: affinity scope is strict
*
- * Work items in this workqueue are affine to these CPUs and not allowed
- * to execute on other CPUs. A pool serving a workqueue must have the
- * same @cpumask.
+ * If clear, workqueue will make a best-effort attempt at starting the
+ * worker inside @__pod_cpumask but the scheduler is free to migrate it
+ * outside.
+ *
+ * If set, workers are only allowed to run inside @__pod_cpumask.
*/
- cpumask_var_t cpumask;
+ bool affn_strict;
/**
* @__pod_cpumask: internal attribute used to create per-pod pools
@@ -166,15 +168,13 @@ struct workqueue_attrs {
cpumask_var_t __pod_cpumask;
/**
- * @affn_strict: affinity scope is strict
- *
- * If clear, workqueue will make a best-effort attempt at starting the
- * worker inside @__pod_cpumask but the scheduler is free to migrate it
- * outside.
+ * @cpumask: allowed CPUs
*
- * If set, workers are only allowed to run inside @__pod_cpumask.
+ * Work items in this workqueue are affine to these CPUs and not allowed
+ * to execute on other CPUs. A pool serving a workqueue must have the
+ * same @cpumask.
*/
- bool affn_strict;
+ cpumask_var_t cpumask;
/*
* Below fields aren't properties of a worker_pool. They only modify how
--
2.19.1.6.gb485710b
next prev parent reply other threads:[~2024-03-08 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 9:42 [PATCH 0/4] workqueue: Some cleanups Lai Jiangshan
2024-03-08 9:42 ` [PATCH 1/4] workqueue: Use INIT_WORK_ONSTACK in workqueue_softirq_dead() Lai Jiangshan
2024-03-25 18:40 ` Tejun Heo
2024-03-08 9:42 ` Lai Jiangshan [this message]
2024-03-25 18:52 ` [PATCH 2/4] workqueue: Reorder the fields in struct workqueue_attrs Tejun Heo
2024-03-08 9:42 ` [PATCH 3/4] workqueue: Move attrs->cpumask out of worker_pool's properties when attrs->affn_strict Lai Jiangshan
2024-03-25 19:12 ` Tejun Heo
2024-03-08 9:42 ` [PATCH 4/4] workqueue: Use list_last_entry() to get the last idle worker Lai Jiangshan
2024-03-25 19:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308094253.2104-3-jiangshanlai@gmail.com \
--to=jiangshanlai@gmail.com \
--cc=jiangshan.ljs@antgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®